Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 795323003: Move Fetch API releted code to modules/fetch. (Closed)

Created:
6 years ago by yhirano
Modified:
6 years ago
Reviewers:
haraken, tasak, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, tyoshino (SeeGerritForStatus)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Fetch API releted code to modules/fetch. Fetch API related code is located on modules/serviceworkers because of a historical reason. Now fetch() function is planned to be exposed to other global scopes and it is natural to have a dedicated directory. modules/serviceworkers depends on modules/fetch. BUG=436770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187356

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -4555 lines) Patch
A + Source/modules/fetch/Body.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/Body.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/modules/fetch/Body.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/BodyStreamBuffer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/FetchHeaderList.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/FetchHeaderList.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/FetchManager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/FetchManager.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + Source/modules/fetch/FetchRequestData.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/FetchRequestData.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/fetch/FetchResponseData.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/FetchResponseData.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/modules/fetch/FetchResponseDataTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/fetch/GlobalFetch.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/GlobalFetch.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/modules/fetch/Headers.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/Headers.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/Headers.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + Source/modules/fetch/Request.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/modules/fetch/Request.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/modules/fetch/Request.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/RequestInit.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/RequestInit.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/modules/fetch/RequestTest.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
A + Source/modules/fetch/Response.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/modules/fetch/Response.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/fetch/Response.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/ResponseInit.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/fetch/ResponseTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/modules/fetch/WindowFetch.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/fetch/WorkerFetch.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 8 chunks +33 lines, -33 lines 0 comments Download
D Source/modules/serviceworkers/Body.h View 1 chunk +0 lines, -105 lines 0 comments Download
D Source/modules/serviceworkers/Body.cpp View 1 chunk +0 lines, -439 lines 0 comments Download
D Source/modules/serviceworkers/Body.idl View 1 chunk +0 lines, -24 lines 0 comments Download
D Source/modules/serviceworkers/BodyStreamBuffer.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/modules/serviceworkers/BodyStreamBuffer.cpp View 1 chunk +0 lines, -146 lines 0 comments Download
D Source/modules/serviceworkers/BodyStreamBufferTest.cpp View 1 chunk +0 lines, -241 lines 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/CacheTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/serviceworkers/FetchHeaderList.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/modules/serviceworkers/FetchHeaderList.cpp View 1 chunk +0 lines, -146 lines 0 comments Download
D Source/modules/serviceworkers/FetchManager.h View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/modules/serviceworkers/FetchManager.cpp View 1 chunk +0 lines, -386 lines 0 comments Download
D Source/modules/serviceworkers/FetchRequestData.h View 1 chunk +0 lines, -116 lines 0 comments Download
D Source/modules/serviceworkers/FetchRequestData.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/modules/serviceworkers/FetchResponseData.h View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/modules/serviceworkers/FetchResponseData.cpp View 1 chunk +0 lines, -283 lines 0 comments Download
D Source/modules/serviceworkers/FetchResponseDataTest.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/modules/serviceworkers/GlobalFetch.h View 1 chunk +0 lines, -27 lines 0 comments Download
D Source/modules/serviceworkers/GlobalFetch.cpp View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/modules/serviceworkers/Headers.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/modules/serviceworkers/Headers.cpp View 1 chunk +0 lines, -353 lines 0 comments Download
D Source/modules/serviceworkers/Headers.idl View 1 chunk +0 lines, -24 lines 0 comments Download
D Source/modules/serviceworkers/Request.h View 1 chunk +0 lines, -84 lines 0 comments Download
D Source/modules/serviceworkers/Request.cpp View 1 chunk +0 lines, -403 lines 0 comments Download
D Source/modules/serviceworkers/Request.idl View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/modules/serviceworkers/RequestInit.h View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/modules/serviceworkers/RequestInit.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
D Source/modules/serviceworkers/RequestTest.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/serviceworkers/Response.h View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/modules/serviceworkers/Response.cpp View 1 chunk +0 lines, -316 lines 0 comments Download
D Source/modules/serviceworkers/Response.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D Source/modules/serviceworkers/ResponseInit.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/modules/serviceworkers/ResponseTest.cpp View 1 chunk +0 lines, -375 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D Source/modules/serviceworkers/WindowFetch.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/modules/serviceworkers/WorkerFetch.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
yhirano
PTAL if you have time. horo@ for modules/. tasak@ for modules dependency.
6 years ago (2014-12-17 03:29:51 UTC) #2
horo
lgtm
6 years ago (2014-12-17 06:21:06 UTC) #3
tasak
lgtm for DEPS
6 years ago (2014-12-17 06:31:01 UTC) #4
yhirano
Thank you! +haraken for Source/web
6 years ago (2014-12-17 06:42:31 UTC) #6
haraken
Source/web/ LGTM
6 years ago (2014-12-17 07:52:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795323003/40001
6 years ago (2014-12-17 07:55:56 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-17 10:12:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187356

Powered by Google App Engine
This is Rietveld 408576698