Fix crash when the source browser window is deleted during a drag

Fix crash when the source browser window is deleted during a drag

This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
the browser window is deleted during a drag-drop operation. An extension can
delete the browser window during the drag-drop operation.

BUG=440534
TEST=BookmarkBarViewTest22.*

Committed: https://crrev.com/460bdd69c6f96191a4293da61e9e4999acd0f5ff
Cr-Commit-Position: refs/heads/master@{#309360}

[pkotwicz, 2014-12-11 22:26:56]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-12-11 22:30:35]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2014-12-11 22:42:07]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2014-12-12 00:02:41]

Patchset #1 (id:60001) has been deleted

[pkotwicz, 2014-12-12 00:37:32]

Patchset #1 (id:80001) has been deleted

[pkotwicz, 2014-12-12 23:26:30]

Patchset #1 (id:100001) has been deleted

[pkotwicz, 2014-12-15 17:39:51]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2014-12-15 17:39:51]

Scott, can you please take a look?

[sky, 2014-12-15 20:44:13]

https://codereview.chromium.org/795303002/diff/120001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc (right):

https://codereview.chromium.org/795303002/diff/120001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc:67: if
(drag_drop_in_progress_)
Should this be a DCHECK?

[pkotwicz, 2014-12-15 21:54:11]

Scott, can you please take another look?

https://codereview.chromium.org/795303002/diff/120001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc (right):

https://codereview.chromium.org/795303002/diff/120001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc:67: if
(drag_drop_in_progress_)
In patch set #2, I moved the check to the destructor

[sky, 2014-12-15 22:59:00]

LGTM

[pkotwicz, 2014-12-16 15:44:46]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-12-16 15:45:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795303002/140001

[commit-bot: I haz the power, 2014-12-16 17:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 17:21:23]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pkotwicz, 2014-12-20 18:46:18]

I am landing this CL with the test disabled on Windows. (So that I can land this
fix during this milestone)

The test started timing out on Windows as a result of
https://codereview.chromium.org/614723003. I have checked. This CL still fixes
the crash on Windows (and Windows does crash without this CL)
The test times out because because:
- DoDragDrop() is a blocking OS call. This stalls MessagePumpForUI::DoRunLoop()
- Work is not scheduled immediately prior to the call to DoDragDrop(). (Calling
MessageLoopForUI::current()->ScheduleWork() immediately prior to the call to
DoDragDrop() makes the test pass)

[pkotwicz, 2014-12-20 18:46:21]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-12-20 18:46:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795303002/160001

[commit-bot: I haz the power, 2014-12-20 20:25:35]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2014-12-20 20:26:15]

Patchset 3 (id:??) landed as
https://crrev.com/460bdd69c6f96191a4293da61e9e4999acd0f5ff
Cr-Commit-Position: refs/heads/master@{#309360}

[Avi (use Gerrit), 2014-12-21 00:36:16]

A revert of this CL (patchset #3 id:160001) has been created in
https://codereview.chromium.org/818983002/ by avi@chromium.org.

The reason for reverting is: Since landing this, Linux ChromiumOS Ozone Tests
(1) is failing three DND tests.

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #1):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #2):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #3):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #4):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_END@DND@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run
#1):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ]
BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run
#2):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ]
BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run
#3):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ]
BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run
#4):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ]
BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_END@DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOrigi...
(run #1):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ]
BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOrigi...
(run #2):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ]
BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOrigi...
(run #3):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ]
BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOrigi...
(run #4):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ]
BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_END@DNDBackToOriginatingMenu@@@
.