Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 795283003: Define HAVE_MKDIR when building for NaCl (Closed)

Created:
6 years ago by Sam Clegg
Modified:
6 years ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Define HAVE_MKDIR when building for NaCl This should enable mktemp() to work. Without this newlib's mkdtemp always return ENOSYS. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4017 R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=312a290217fd4a5f0c3fa43aac99c8e07de9143d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M newlib/configure.host View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sam Clegg
6 years ago (2014-12-12 00:38:14 UTC) #2
Roland McGrath
lgtm with green toolchain trybots (tools/toolchain-git-try.sh)
6 years ago (2014-12-12 00:40:05 UTC) #3
Sam Clegg
6 years ago (2014-12-12 17:48:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
312a290217fd4a5f0c3fa43aac99c8e07de9143d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698