Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Issue 795253007: Fix install-build-deps.sh --quick-check on Trusty (Closed)

Created:
5 years, 11 months ago by johnme
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix install-build-deps.sh --quick-check on Trusty Sort :i386 packages to the front to avoid confusing dpkg-query; see https://crbug.com/446172 for details. BUG=446172 Committed: https://crrev.com/4bd1030a750284a3c2f75757f7d686f269bf9690 Cr-Commit-Position: refs/heads/master@{#310079}

Patch Set 1 #

Patch Set 2 : Simplify patch #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/install-build-deps.sh View 1 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
johnme
5 years, 11 months ago (2015-01-05 15:05:30 UTC) #2
Nico
lgtm https://codereview.chromium.org/795253007/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/795253007/diff/20001/build/install-build-deps.sh#newcode311 build/install-build-deps.sh:311: "${nacl_list}" | tr " " "\n" | sort ...
5 years, 11 months ago (2015-01-05 20:53:08 UTC) #3
johnme
https://codereview.chromium.org/795253007/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/795253007/diff/20001/build/install-build-deps.sh#newcode311 build/install-build-deps.sh:311: "${nacl_list}" | tr " " "\n" | sort -u ...
5 years, 11 months ago (2015-01-06 10:45:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795253007/20001
5 years, 11 months ago (2015-01-06 10:46:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 11:26:22 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 11:27:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bd1030a750284a3c2f75757f7d686f269bf9690
Cr-Commit-Position: refs/heads/master@{#310079}

Powered by Google App Engine
This is Rietveld 408576698