Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 795223002: Fix some win64 warnings. (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/core/SkDescriptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkVarAlloc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +2 lines, -2 lines 2 comments Download
M src/gpu/GrProgramDesc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bsalomon
We still don't have warnings-as-errors on for win 64 builds. This silences some of the ...
6 years ago (2014-12-11 20:42:11 UTC) #2
mtklein
lgtm
6 years ago (2014-12-11 20:44:34 UTC) #3
robertphillips
lgtm
6 years ago (2014-12-11 20:47:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795223002/1
6 years ago (2014-12-11 20:47:33 UTC) #6
reed1
https://codereview.chromium.org/795223002/diff/1/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/795223002/diff/1/src/gpu/GrDistanceFieldTextContext.cpp#newcode309 src/gpu/GrDistanceFieldTextContext.cpp:309: fallbackTxt.push_back_n(SkToU32(text-lastText), lastText); SkToInt ?
6 years ago (2014-12-11 20:56:26 UTC) #8
bsalomon
6 years ago (2014-12-11 21:08:47 UTC) #9 
https://codereview.chromium.org/795223002/diff/1/src/gpu/GrDistanceFieldTextC...
File src/gpu/GrDistanceFieldTextContext.cpp (right):

https://codereview.chromium.org/795223002/diff/1/src/gpu/GrDistanceFieldTextC...
src/gpu/GrDistanceFieldTextContext.cpp:309:
fallbackTxt.push_back_n(SkToU32(text-lastText), lastText);
On 2014/12/11 20:56:26, reed1 wrote:
> SkToInt ?

Imminent CL will fix the casts that should have been to int not uint32 and fix
more warnings.

Powered by Google App Engine
This is Rietveld 408576698