Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 795153003: Push API: rename to endpoint and registrationId. [2/3] (Closed)

Created:
6 years ago by Michael van Ouwerkerk
Modified:
6 years ago
Reviewers:
Peter Beverloo
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Push API: rename to endpoint and registrationId. [2/3] This is part of a series: [1] https://codereview.chromium.org/805863002/ [2] This CL [3] https://codereview.chromium.org/802393002/ BUG=442343 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187244

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M LayoutTests/http/tests/push_messaging/register_success.html View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/push_messaging/PushRegistration.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/push_messaging/PushRegistration.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/push_messaging/PushRegistration.idl View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
6 years ago (2014-12-15 16:58:26 UTC) #2
Peter Beverloo
On 2014/12/15 16:58:26, Michael van Ouwerkerk wrote: > Peter, could you take a look please? ...
6 years ago (2014-12-15 17:01:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795153003/20001
6 years ago (2014-12-16 11:56:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-16 11:59:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187244

Powered by Google App Engine
This is Rietveld 408576698