Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 795093004: Make TransportData (and thus MessageInTransit) be able to simply carry platform handles. (Closed)

Created:
5 years, 11 months ago by viettrungluu
Modified:
5 years, 11 months ago
Reviewers:
yzshen1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make TransportData (and thus MessageInTransit) be able to simply carry platform handles. (And not require dispatchers.) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6c6afec8f377c98af06240225b39b621fd408124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -23 lines) Patch
M mojo/edk/system/raw_channel_unittest.cc View 3 chunks +123 lines, -1 line 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/transport_data.h View 2 chunks +5 lines, -8 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 3 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 11 months ago (2015-01-12 22:36:47 UTC) #1
yzshen1
LGTM
5 years, 11 months ago (2015-01-12 23:34:16 UTC) #2
viettrungluu
5 years, 11 months ago (2015-01-13 00:17:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c6afec8f377c98af06240225b39b621fd408124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698