Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 795053007: Replace TraceEvent.begin()/end() with explicit names (Closed)

Created:
6 years ago by mkosiba (inactive)
Modified:
6 years ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace TraceEvent.begin()/end() with explicit names Replace TraceEvent.begin()/end() calls which implicitly gets the trace event name by doing a costly stack dump, with explicitly named trace event names. Also wrap traces around try/finally. BUG=439118 Committed: https://crrev.com/198d7e12e38a43424fd73f38b8b0270487aba2a0 Cr-Commit-Position: refs/heads/master@{#307974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -371 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java View 22 chunks +500 lines, -371 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
boliu
lgtm
6 years ago (2014-12-11 19:07:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795053007/1
6 years ago (2014-12-11 19:08:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 21:05:07 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 21:05:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/198d7e12e38a43424fd73f38b8b0270487aba2a0
Cr-Commit-Position: refs/heads/master@{#307974}

Powered by Google App Engine
This is Rietveld 408576698