[Password Manager] Close the bubble when fullscreen state gets change.

chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h

Index: chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h
diff --git a/chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h b/chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..a692b9ac389fadc239de88a6942bed170ce8ebfd
--- /dev/null
+++ b/chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h
@@ -0,0 +1,50 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_MANAGED_FULL_SCREEN_BUBBLE_DELEGATE_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_MANAGED_FULL_SCREEN_BUBBLE_DELEGATE_VIEW_H_
+
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "ui/views/bubble/bubble_delegate.h"
+
+namespace content {
+class NotificationDetails;
+class NotificationSource;
+class WebContents;
+};
+
+// View used to display the bubble popup and closes on browser's full screen
+// transition notifications.

[Peter Kasting, 2014/12/19 22:11:36]

This comment has grammar issues.  Perhaps you want something like this:

View used to automatically close a bubble when the browser transitions in or out
of fullscreen mode.

[Pritam Nikam, 2014/12/22 08:19:10]

Done.

+class ManagedFullScreenBubbleDelegateView
+    : public views::BubbleDelegateView,
+      public content::NotificationObserver {
+ public:
+  ManagedFullScreenBubbleDelegateView(views::View* anchor_view,
+                                      content::WebContents* web_contents);
+  ~ManagedFullScreenBubbleDelegateView() override;
+
+  // content::NotificationObserver:
+  void Observe(int type,
+               const content::NotificationSource& source,
+               const content::NotificationDetails& details) override;
+
+ protected:

[Peter Kasting, 2014/12/19 22:11:36]

I only see Close() getting overridden.  Does AdjustForFullscreen() really need
to be protected as well, or can it be private?

[Pritam Nikam, 2014/12/22 08:19:10]

Done.

+  // If the bubble is not anchored to a view, places the bubble in the top right
+  // (left in RTL) of the |screen_bounds| that contain web contents's browser
+  // window. Because the positioning is based on the size of the bubble, this
+  // must be called after the bubble is created.
+  void AdjustForFullscreen(const gfx::Rect& screen_bounds);
+
+  // Close the bubble.

[Peter Kasting, 2014/12/19 22:11:36]

Nit: Closes

I also suggest listing virtual methods before non-virtual ones.

[Pritam Nikam, 2014/12/22 08:19:10]

Done.

+  virtual void Close();
+
+ private:
+  // Used to register for fullscreen change notifications.
+  content::NotificationRegistrar registrar_;
+
+  DISALLOW_COPY_AND_ASSIGN(ManagedFullScreenBubbleDelegateView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_MANAGED_FULL_SCREEN_BUBBLE_DELEGATE_VIEW_H_