[Password Manager] Close the bubble when fullscreen state gets change.

chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc

Index: chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc
diff --git a/chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc b/chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6120e50ab86075acdf266ac46da819ca7833b774
--- /dev/null
+++ b/chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc
@@ -0,0 +1,76 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h"
+
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
+#include "content/public/browser/notification_source.h"
+#include "ui/gfx/geometry/rect.h"
+
+namespace {
+
+// The bubble's padding from the screen edge, used in fullscreen.
+const int kFullscreenPaddingEnd = 20;
+
+}  // namespace
+
+ManagedFullScreenBubbleDelegateView::ManagedFullScreenBubbleDelegateView(
+    views::View* anchor_view,
+    content::WebContents* web_contents)
+    : BubbleDelegateView(anchor_view,
+                         anchor_view ? views::BubbleBorder::TOP_RIGHT
+                                     : views::BubbleBorder::NONE) {
+  // Register accelerator key F11.
+  AddAccelerator(ui::Accelerator(ui::VKEY_F11, ui::EF_NONE));
+
+  // Add observer to close the bubble if the fullscreen state changes.
+  if (web_contents) {

[vasilii, 2014/12/18 16:16:22]

Can it be NULL?

[Pritam Nikam, 2014/12/19 09:16:54]

I don't think it can be NULL in practical cases, however this check is
specifically added to address unit_tests failures:

TranslateBubbleViewTest.TryAgainButton
TranslateBubbleViewTest.DoneButton
TranslateBubbleViewTest.AlwaysTranslateCheckboxAndCancelButton
TranslateBubbleViewTest.ShowOriginalButton
TranslateBubbleViewTest.TranslateButton
TranslateBubbleViewTest.CancelButtonReturningAfterTranslate
TranslateBubbleViewTest.AlwaysTranslateCheckboxAndDoneButton
TranslateBubbleViewTest.AdvancedLink
TranslateBubbleViewTest.CancelButtonReturningBeforeTranslate
TranslateBubbleViewTest.CancelButtonReturningError
TranslateBubbleViewTest.DoneButtonWithoutTranslating

+    Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
+    registrar_.Add(this, chrome::NOTIFICATION_FULLSCREEN_CHANGED,
+                   content::Source<FullscreenController>(
+                       browser->fullscreen_controller()));
+  }
+}
+
+ManagedFullScreenBubbleDelegateView::~ManagedFullScreenBubbleDelegateView() {
+}
+
+void ManagedFullScreenBubbleDelegateView::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  DCHECK_EQ(type, chrome::NOTIFICATION_FULLSCREEN_CHANGED);
+  GetWidget()->SetVisibilityAnimationTransition(views::Widget::ANIMATE_NONE);
+  Close();
+}
+
+void ManagedFullScreenBubbleDelegateView::AdjustForFullscreen(
+    const gfx::Rect& screen_bounds) {
+  if (GetAnchorView())
+    return;
+
+  const int bubble_half_width = width() / 2;
+  const int x_pos =
+      base::i18n::IsRTL()
+          ? screen_bounds.x() + bubble_half_width + kFullscreenPaddingEnd
+          : screen_bounds.right() - bubble_half_width - kFullscreenPaddingEnd;
+  SetAnchorRect(gfx::Rect(x_pos, screen_bounds.y(), 0, 0));
+}
+
+bool ManagedFullScreenBubbleDelegateView::AcceleratorPressed(
+    const ui::Accelerator& accelerator) {
+  if (accelerator.key_code() == ui::VKEY_F11) {
+    Close();
+    return true;
+  }
+
+  return BubbleDelegateView::AcceleratorPressed(accelerator);
+}
+
+void ManagedFullScreenBubbleDelegateView::Close() {
+  GetWidget()->Close();
+}