[Password Manager] Close the bubble when fullscreen state gets change.

chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h"
+
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
+#include "content/public/browser/notification_source.h"
+#include "ui/gfx/geometry/rect.h"
+
+namespace {
+
+// The bubble's padding from the screen edge, used in fullscreen.
+const int kFullscreenPaddingEnd = 20;

[Peter Kasting, 2014/12/19 22:11:35]

Nit: Declare this in the lone function where it's used.

[Pritam Nikam, 2014/12/22 08:19:09]

Done.

+
+}  // namespace
+
+ManagedFullScreenBubbleDelegateView::ManagedFullScreenBubbleDelegateView(
+    views::View* anchor_view,
+    content::WebContents* web_contents)
+    : BubbleDelegateView(anchor_view,
+                         (anchor_view ? views::BubbleBorder::TOP_RIGHT
+                                      : views::BubbleBorder::NONE)) {

[Peter Kasting, 2014/12/19 22:11:35]

Nit: Wrap like:

    : BubbleDelegateView(
        anchor_view,
        anchor_view ?
            views::BubbleBorder::TOP_RIGHT : views::BubbleBorder::NONE) {

[Pritam Nikam, 2014/12/22 08:19:09]

Done.

+  // Add observer to close the bubble if the fullscreen state changes.
+  if (web_contents) {
+    Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
+    registrar_.Add(this, chrome::NOTIFICATION_FULLSCREEN_CHANGED,
+                   content::Source<FullscreenController>(
+                       browser->fullscreen_controller()));
+  }
+}
+
+ManagedFullScreenBubbleDelegateView::~ManagedFullScreenBubbleDelegateView() {
+}
+
+void ManagedFullScreenBubbleDelegateView::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  DCHECK_EQ(type, chrome::NOTIFICATION_FULLSCREEN_CHANGED);

[Peter Kasting, 2014/12/19 22:11:35]

Nit: (expected, actual)

[Pritam Nikam, 2014/12/22 08:19:10]

Done.

+  GetWidget()->SetVisibilityAnimationTransition(views::Widget::ANIMATE_NONE);
+  Close();
+}
+
+void ManagedFullScreenBubbleDelegateView::AdjustForFullscreen(
+    const gfx::Rect& screen_bounds) {
+  if (GetAnchorView())
+    return;
+
+  const int bubble_half_width = width() / 2;

[Peter Kasting, 2014/12/19 22:11:35]

Nit: While I'm fine with them, most Chromium code omits const declarations on
local non-pointer/ref variables.

[Pritam Nikam, 2014/12/22 08:19:09]

Done.

+  const int x_pos =
+      (base::i18n::IsRTL()

[Peter Kasting, 2014/12/19 22:11:35]

Nit: Don't parenthesize entire RHS.

[Pritam Nikam, 2014/12/22 08:19:09]

Done.

+           ? (screen_bounds.x() + bubble_half_width + kFullscreenPaddingEnd)
+           : (screen_bounds.right() - bubble_half_width -
+              kFullscreenPaddingEnd));

[Peter Kasting, 2014/12/19 22:11:35]

Nit: Wrap like:

  const int x_pos = base::i18n::IsRTL() ?
      (screen_bounds.x() + bubble_half_width + kFullscreenPaddingEnd) :
      (screen_bounds.right() - bubble_half_width - kFullscreenPaddingEnd);

[Pritam Nikam, 2014/12/22 08:19:09]

Done.

+  SetAnchorRect(gfx::Rect(x_pos, screen_bounds.y(), 0, 0));
+}
+
+void ManagedFullScreenBubbleDelegateView::Close() {
+  GetWidget()->Close();
+}