Issue 795043003: [turbofan] commit allocated registers early

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 795043003: [turbofan] commit allocated registers early (Closed)

Created:
6 years ago by dcarney

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] commit allocated registers early R=bmeurer@chromium.org BUG=441107 LOG=N

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/compiler/register-allocator.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/compiler/register-allocator.cc	View		3 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

LGTM https://codereview.chromium.org/795043003/diff/1/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/795043003/diff/1/src/compiler/register-allocator.cc#newcode142 src/compiler/register-allocator.cc:142: ConvertUsesToOperand(CreateAssignedOperand(zone)); Urghs...

6 years ago (2014-12-11 11:45:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795043003/1

6 years ago (2014-12-11 11:46:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages