Chromium Code Reviews
Help | Chromium Project | Sign in
(618)

Issue 795006: When using SSLClientSocketNSS on Windows, fall back on SSLClientSocketWin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

When using NSS for SSL on Windows, fall back on SSLClientSocketWin
if the server requests a client certificate. This is an interim
solution until we modify SSLClientSocketNSS to use CryptoAPI to
do SSL client authentication.

R=mbelshe
BUG=37560
TEST=SSL client authentication should continue to work on Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41444

Patch Set 1 #

Total comments: 1

Patch Set 2 : Log an error message if we can't open the MY system certificate store. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -14 lines) Lint Patch
M net/socket/ssl_client_socket_nss.h View 1 chunk +6 lines, -3 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.cc View 1 5 chunks +82 lines, -11 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss_factory.cc View 2 chunks +12 lines, -0 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_win.cc View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
wtc
4 years, 1 month ago #1
Mike Belshe
lgtm http://codereview.chromium.org/795006/diff/1/4 File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/795006/diff/1/4#newcode1120 net/socket/ssl_client_socket_nss.cc:1120: if (!my_cert_store) nit: You could log the GetLastError() ...
4 years, 1 month ago #2
wtc
4 years, 1 month ago #3
Thanks for the review.  I added the error log message that
you suggested in Patch Set 2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6