Chromium Code Reviews
Help | Chromium Project | Sign in
(403)

Issue 795006: When using SSLClientSocketNSS on Windows, fall back on SSLClientSocketWin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by wtc
Modified:
4 years, 2 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

When using NSS for SSL on Windows, fall back on SSLClientSocketWin if the server requests a client certificate. This is an interim solution until we modify SSLClientSocketNSS to use CryptoAPI to do SSL client authentication. R=mbelshe BUG=37560 TEST=SSL client authentication should continue to work on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41444

Patch Set 1 #

Total comments: 1

Patch Set 2 : Log an error message if we can't open the MY system certificate store. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -14 lines) Patch
M net/socket/ssl_client_socket_nss.h View 1 chunk +6 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 5 chunks +82 lines, -11 lines 0 comments Download
M net/socket/ssl_client_socket_nss_factory.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
wtc
5 years, 4 months ago (2010-03-10 22:55:24 UTC) #1
Mike Belshe
lgtm http://codereview.chromium.org/795006/diff/1/4 File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/795006/diff/1/4#newcode1120 net/socket/ssl_client_socket_nss.cc:1120: if (!my_cert_store) nit: You could log the GetLastError() ...
5 years, 4 months ago (2010-03-11 17:18:42 UTC) #2
wtc
5 years, 4 months ago (2010-03-11 18:19:40 UTC) #3
Thanks for the review.  I added the error log message that
you suggested in Patch Set 2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5