Separate X11 implementation of touch log source

Separate X11 implementation of touch log source

The CL separates the X11 implementation into an independent file so
one may implement different versions for other platforms (e.g.,
ozone). To avoid compilation error, a stub ozone implementation is
also added.

Contributed by sheckylin@chromium.org

BUG=400022
TEST=link and link_freon ChromeOS build

Committed: https://crrev.com/3cde4bcce246045eacce886ee4ec53d61efe63fd
Cr-Commit-Position: refs/heads/master@{#308071}

[Shecky Lin, 2014-12-11 09:40:45]

sheckylin@chromium.org changed reviewers:
+ achuith@chromium.org, alexst@chromium.org, spang@chromium.org

[Shecky Lin, 2014-12-11 09:42:42]

Hey guys,

This is the preparatory CL to separate the implementation of touch log source.
It is similar to what we have done for input device settings.

Please take a look. Thanks everyone!

[achuithb, 2014-12-11 20:19:09]

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
File chrome/browser/chromeos/system_logs/touch_log_source.cc (right):

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source.cc:9:
TouchLogSource::TouchLogSource() : SystemLogsSource("Touch") {
Any reason to not move these to the header file and just delete this cc file
altogether?

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
File chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc (right):

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc:1: // Copyright
2014 The Chromium Authors. All rights reserved.
Was this changed by clang_format? If not, don't change this.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc:33: //
TODO(sheckylin): Add ozone touch log collection implementation.
Let's add a tracking bug id here as well.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc:47: FROM_HERE,
base::Bind(&GetTouchLogsOzone, response),
Is this clang_format? If not, I think having base::Bind on the next line is
better.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
File chrome/browser/chromeos/system_logs/touch_log_source_x11.cc (right):

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_x11.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
same as before

[Shecky Lin, 2014-12-12 08:31:22]

Please take another look. Thanks!

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
File chrome/browser/chromeos/system_logs/touch_log_source.cc (right):

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source.cc:9:
TouchLogSource::TouchLogSource() : SystemLogsSource("Touch") {
On 2014/12/11 20:19:08, achuithb wrote:
> Any reason to not move these to the header file and just delete this cc file
> altogether?

Done.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
File chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc (right):

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2014/12/11 20:19:08, achuithb wrote:
> Was this changed by clang_format? If not, don't change this.

Done.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc:33: //
TODO(sheckylin): Add ozone touch log collection implementation.
On 2014/12/11 20:19:08, achuithb wrote:
> Let's add a tracking bug id here as well.

Done.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc:47: FROM_HERE,
base::Bind(&GetTouchLogsOzone, response),
On 2014/12/11 20:19:08, achuithb wrote:
> Is this clang_format? If not, I think having base::Bind on the next line is
> better.

It is clang_format. I'm keeping it thereby.

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
File chrome/browser/chromeos/system_logs/touch_log_source_x11.cc (right):

https://codereview.chromium.org/794943003/diff/1/chrome/browser/chromeos/syst...
chrome/browser/chromeos/system_logs/touch_log_source_x11.cc:1: // Copyright 2014
The Chromium Authors. All rights reserved.
On 2014/12/11 20:19:08, achuithb wrote:
> same as before

Done.

[Shecky Lin, 2014-12-12 08:32:42]

sheckylin@chromium.org changed reviewers:
+ adlr@chromium.org

[achuithb, 2014-12-12 08:42:56]

lgtm

https://codereview.chromium.org/794943003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/system_logs/touch_log_source.cc (left):

https://codereview.chromium.org/794943003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/system_logs/touch_log_source.cc:1: // Copyright (c) 2013
The Chromium Authors. All rights reserved.
This file shows up as M instead of D, is that right? You want to delete, not
truncate.

[Shecky Lin, 2014-12-12 08:46:52]

The CQ bit was checked by sheckylin@chromium.org

[commit-bot: I haz the power, 2014-12-12 08:47:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/794943003/40001

[commit-bot: I haz the power, 2014-12-12 14:37:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-12 14:39:09]

Patchset 3 (id:??) landed as
https://crrev.com/3cde4bcce246045eacce886ee4ec53d61efe63fd
Cr-Commit-Position: refs/heads/master@{#308071}