Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 794943002: sync setup: Restore previous behavior to focus() passphrase. (Closed)

Created:
6 years ago by Dan Beam
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

sync setup: Restore previous behavior to focus() passphrase. R=dmazzoni@chromium.org BUG=437745 Committed: https://crrev.com/8643047578c456a73ea9695b70760c8d6e52c657 Cr-Commit-Position: refs/heads/master@{#308023}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/options/sync_setup_overlay.js View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
Dan Beam
https://codereview.chromium.org/794943002/diff/1/chrome/browser/resources/options/sync_setup_overlay.js File chrome/browser/resources/options/sync_setup_overlay.js (right): https://codereview.chromium.org/794943002/diff/1/chrome/browser/resources/options/sync_setup_overlay.js#newcode705 chrome/browser/resources/options/sync_setup_overlay.js:705: // TODO(dbeam): add an #updatePassphrase and only focus with ...
6 years ago (2014-12-11 01:00:12 UTC) #1
dmazzoni
lgtm
6 years ago (2014-12-11 23:28:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794943002/1
6 years ago (2014-12-11 23:29:17 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years ago (2014-12-12 01:32:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794943002/1
6 years ago (2014-12-12 01:34:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 02:01:18 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 02:02:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8643047578c456a73ea9695b70760c8d6e52c657
Cr-Commit-Position: refs/heads/master@{#308023}

Powered by Google App Engine
This is Rietveld 408576698