Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: build/android/test_runner.py

Issue 794923003: [Android] Implement instrumentation tests in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/local/device/local_device_test_run.py ('k') | chrome/chrome_shell_test_apk.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index c1fb450b9071cb8234e5a9515d4ccd266d940223..049b1ab9be3252cff415ca5d1d8afd8383b19174 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -293,6 +293,8 @@ def AddInstrumentationTestOptions(parser):
group.add_argument('-w', '--wait_debugger', dest='wait_for_debugger',
action='store_true',
help='Wait for debugger.')
+ group.add_argument('--apk-under-test', dest='apk_under_test',
+ help=('the name of the apk under test.'))
group.add_argument('--test-apk', dest='test_apk', required=True,
help=('The name of the apk containing the tests '
'(without the .apk extension; '
@@ -303,6 +305,9 @@ def AddInstrumentationTestOptions(parser):
group.add_argument('--device-flags', dest='device_flags', default='',
help='The relative filepath to a file containing '
'command-line flags to set on the device')
+ group.add_argument('--device-flags-file', default='',
+ help='The relative filepath to a file containing '
+ 'command-line flags to set on the device')
group.add_argument('--isolate_file_path',
'--isolate-file-path',
dest='isolate_file_path',
@@ -898,7 +903,9 @@ def RunTestsCommand(args, parser):
_SUPPORTED_IN_PLATFORM_MODE = [
# TODO(jbudorick): Add support for more test types.
- 'gtest', 'uirobot',
+ 'gtest',
+ 'instrumentation',
+ 'uirobot',
]
@@ -913,7 +920,7 @@ def RunTestsInPlatformMode(args, parser):
args, env, test, parser.error) as test_run:
results = test_run.RunTests()
- if args.trigger:
+ if args.environment == 'remote_device' and args.trigger:
return 0 # Not returning results, only triggering.
report_results.LogFull(
« no previous file with comments | « build/android/pylib/local/device/local_device_test_run.py ('k') | chrome/chrome_shell_test_apk.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698