Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3515)

Unified Diff: build/android/pylib/base/test_run_factory.py

Issue 794923003: [Android] Implement instrumentation tests in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/base/test_run_factory.py
diff --git a/build/android/pylib/base/test_run_factory.py b/build/android/pylib/base/test_run_factory.py
index c8e0582034a500bf7c9a759967aa2fb2885a7b18..3f00caaceb4d628cb5d0712c55fa6b7be416add1 100644
--- a/build/android/pylib/base/test_run_factory.py
+++ b/build/android/pylib/base/test_run_factory.py
@@ -4,7 +4,9 @@
from pylib.gtest import gtest_test_instance
from pylib.gtest import local_device_gtest_run
+from pylib.instrumentation import instrumentation_test_instance
from pylib.local.device import local_device_environment
+from pylib.local.device import local_device_instrumentation_test_run
from pylib.remote.device import remote_device_environment
from pylib.remote.device import remote_device_gtest_run
from pylib.remote.device import remote_device_uirobot_run
@@ -15,16 +17,19 @@ def CreateTestRun(_args, env, test_instance, error_func):
if isinstance(env, local_device_environment.LocalDeviceEnvironment):
if isinstance(test_instance, gtest_test_instance.GtestTestInstance):
return local_device_gtest_run.LocalDeviceGtestRun(env, test_instance)
+ if isinstance(test_instance,
+ instrumentation_test_instance.InstrumentationTestInstance):
+ return (local_device_instrumentation_test_run
+ .LocalDeviceInstrumentationTestRun(env, test_instance))
if isinstance(env, remote_device_environment.RemoteDeviceEnvironment):
if isinstance(test_instance, gtest_test_instance.GtestTestInstance):
return remote_device_gtest_run.RemoteDeviceGtestRun(env, test_instance)
+ # TODO(rnephew): Add remote_device instrumentation test runs.
if isinstance(test_instance, uirobot_test_instance.UirobotTestInstance):
return remote_device_uirobot_run.RemoteDeviceUirobotRun(
env, test_instance)
- # TODO(jbudorick): Add local instrumentation test runs.
- # TODO(rnephew): Add remote_device instrumentation test runs.
error_func('Unable to create test run for %s tests in %s environment'
% (str(test_instance), str(env)))

Powered by Google App Engine
This is Rietveld 408576698