Subzero: Use llvm::ilist<> for PhiList and AssignList.

src/IceDefs.h

 //===- subzero/src/IceDefs.h - Common Subzero declaraions -------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares various useful types and classes that have
@@ skipping 42 matching lines @@
 class Operand;
 class TargetLowering;
 class Variable;
 class VariableDeclaration;
 class VariablesMetadata;
 
 // TODO: Switch over to LLVM's ADT container classes.
 // http://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task
 typedef std::string IceString;
 typedef llvm::ilist<Inst> InstList;
-typedef std::list<InstAssign *> AssignList;
-typedef std::list<InstPhi *> PhiList;
+// Ideally PhiList would be llvm::ilist<InstPhi>, and similar for
+// AssignList, but this runs into issues with SFINAE.
+typedef InstList PhiList;
+typedef InstList AssignList;
 typedef std::vector<Variable *> VarList;
-typedef std::vector<Operand *> OperandList;
 typedef std::vector<CfgNode *> NodeList;
 typedef std::vector<Constant *> ConstantList;
 
 // SizeT is for holding small-ish limits like number of source
 // operands in an instruction.  It is used instead of size_t (which
 // may be 64-bits wide) when we want to save space.
 typedef uint32_t SizeT;
 
 // InstNumberT is for holding an instruction number.  Instruction
 // numbers are used for representing Variable live ranges.
@@ skipping 48 matching lines @@
   IceV_Most = IceV_All & ~IceV_LinearScan
 };
 typedef uint32_t VerboseMask;
 
 typedef llvm::raw_ostream Ostream;
 typedef llvm::raw_fd_ostream Fdstream;
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEDEFS_H