Isolate ui_touch_selection_unittests

Isolate ui_touch_selection_unittests

It was added to ui/ while I isolated all other unittests in ui/

BUG=98637
TBR=jam@chromium.org

Committed: https://crrev.com/82ba8d9421a85329aaf4bdc7e555d15bdf3da6cf
Cr-Commit-Position: refs/heads/master@{#308618}

[jochen (gone - plz use gerrit), 2014-12-16 16:14:53]

jochen@chromium.org changed reviewers:
+ jam@chromium.org, maruel@chromium.org

[jochen (gone - plz use gerrit), 2014-12-16 16:14:53]

ptal

I'm ommiting windows, because... windows

[M-A Ruel, 2014-12-16 17:21:59]

lgtm

[jochen (gone - plz use gerrit), 2014-12-16 17:28:18]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-12-16 17:29:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/794903004/20001

[commit-bot: I haz the power, 2014-12-16 18:30:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-16 18:31:41]

Patchset 2 (id:??) landed as
https://crrev.com/82ba8d9421a85329aaf4bdc7e555d15bdf3da6cf
Cr-Commit-Position: refs/heads/master@{#308618}

[Nico, 2015-01-23 23:31:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-01-23 23:31:21]

https://codereview.chromium.org/794903004/diff/20001/ui/touch_selection/ui_to...
File ui/touch_selection/ui_touch_selection_unittests.isolate (right):

https://codereview.chromium.org/794903004/diff/20001/ui/touch_selection/ui_to...
ui/touch_selection/ui_touch_selection_unittests.isolate:48:
'<(PRODUCT_DIR)/osmesa.dll',
I'm getting

FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x86
ui_touch_selection_unittests_run_target_isolate_ac999537c278e3de8219fa329608ca8a.9b407c7a0507cc353c9121362e826281.rsp
..\..\ui\touch_selection
Traceback (most recent call last):
  File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 1212, in
<module>
    sys.exit(main(sys.argv[1:]))
  File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 1205, in
main
    return dispatcher.execute(parser, argv)
  File
"D:\src\chromefetch\src\tools\swarming_client\third_party\depot_tools\subcommand.py",
line 242, in execute
    return command(parser, args[1:])
  File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 945, in
CMDcheck
    options, os.getcwd(), options.subdir, False)
  File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 676, in
load_complete_state
    options.extra_variables, options.blacklist, options.ignore_broken_items)
  File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 560, in
load_isolate
    ignore_broken_items)
  File "D:\src\chromefetch\src\tools\swarming_client\isolated_format.py", line
300, in expand_directories_and_symlinks
    indir, relfile, blacklist, follow_symlinks))
  File "D:\src\chromefetch\src\tools\swarming_client\isolated_format.py", line
283, in expand_directory_and_symlink
    raise MappingError('Input file %s doesn\'t exist' % infile)
isolated_format.MappingError: Input file
D:\src\chromefetch\src\out\Release\osmesa.dll doesn't exist
[5731/19355] CXX obj\v8\src\heap\v8_base.heap.obj


Looks like ui_touch_selection_unittests in the gyp file doesn't declare a dep on
this – if the isolate lists this, it probably should?

[M-A Ruel, 2015-01-24 00:04:03]

On 2015/01/23 23:31:21, Nico wrote:
>
https://codereview.chromium.org/794903004/diff/20001/ui/touch_selection/ui_to...
> File ui/touch_selection/ui_touch_selection_unittests.isolate (right):
> 
>
https://codereview.chromium.org/794903004/diff/20001/ui/touch_selection/ui_to...
> ui/touch_selection/ui_touch_selection_unittests.isolate:48:
> '<(PRODUCT_DIR)/osmesa.dll',
> I'm getting
> 
> FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool
action-wrapper
> environment.x86
>
ui_touch_selection_unittests_run_target_isolate_ac999537c278e3de8219fa329608ca8a.9b407c7a0507cc353c9121362e826281.rsp
> ..\..\ui\touch_selection
> Traceback (most recent call last):
>   File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 1212,
in
> <module>
>     sys.exit(main(sys.argv[1:]))
>   File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 1205,
in
> main
>     return dispatcher.execute(parser, argv)
>   File
>
"D:\src\chromefetch\src\tools\swarming_client\third_party\depot_tools\subcommand.py",
> line 242, in execute
>     return command(parser, args[1:])
>   File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 945, in
> CMDcheck
>     options, os.getcwd(), options.subdir, False)
>   File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 676, in
> load_complete_state
>     options.extra_variables, options.blacklist, options.ignore_broken_items)
>   File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line 560, in
> load_isolate
>     ignore_broken_items)
>   File "D:\src\chromefetch\src\tools\swarming_client\isolated_format.py", line
> 300, in expand_directories_and_symlinks
>     indir, relfile, blacklist, follow_symlinks))
>   File "D:\src\chromefetch\src\tools\swarming_client\isolated_format.py", line
> 283, in expand_directory_and_symlink
>     raise MappingError('Input file %s doesn\'t exist' % infile)
> isolated_format.MappingError: Input file
> D:\src\chromefetch\src\out\Release\osmesa.dll doesn't exist
> [5731/19355] CXX obj\v8\src\heap\v8_base.heap.obj

I'll cleanup the error message, it's kind of ridiculous.


> Looks like ui_touch_selection_unittests in the gyp file doesn't declare a dep
on
> this – if the isolate lists this, it probably should?

Yep.

[Nico, 2015-01-24 01:01:43]

On Fri, Jan 23, 2015 at 4:04 PM, <maruel@chromium.org> wrote:

> On 2015/01/23 23:31:21, Nico wrote:
>
> https://codereview.chromium.org/794903004/diff/20001/ui/
> touch_selection/ui_touch_selection_unittests.isolate
>
>> File ui/touch_selection/ui_touch_selection_unittests.isolate (right):
>>
>
>
> https://codereview.chromium.org/794903004/diff/20001/ui/
> touch_selection/ui_touch_selection_unittests.isolate#newcode48
>
>> ui/touch_selection/ui_touch_selection_unittests.isolate:48:
>> '<(PRODUCT_DIR)/osmesa.dll',
>> I'm getting
>>
>
>  FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool
>>
> action-wrapper
>
>> environment.x86
>>
>
> ui_touch_selection_unittests_run_target_isolate_
> ac999537c278e3de8219fa329608ca8a.9b407c7a0507cc353c9121362e826281.rsp
>
>> ..\..\ui\touch_selection
>> Traceback (most recent call last):
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line
>> 1212,
>>
> in
>
>> <module>
>>      sys.exit(main(sys.argv[1:]))
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line
>> 1205,
>>
> in
>
>> main
>>      return dispatcher.execute(parser, argv)
>>    File
>>
>
> "D:\src\chromefetch\src\tools\swarming_client\third_party\
> depot_tools\subcommand.py",
>
>> line 242, in execute
>>      return command(parser, args[1:])
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line
>> 945, in
>> CMDcheck
>>      options, os.getcwd(), options.subdir, False)
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line
>> 676, in
>> load_complete_state
>>      options.extra_variables, options.blacklist,
>> options.ignore_broken_items)
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolate.py", line
>> 560, in
>> load_isolate
>>      ignore_broken_items)
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolated_format.py",
>> line
>> 300, in expand_directories_and_symlinks
>>      indir, relfile, blacklist, follow_symlinks))
>>    File "D:\src\chromefetch\src\tools\swarming_client\isolated_format.py",
>> line
>> 283, in expand_directory_and_symlink
>>      raise MappingError('Input file %s doesn\'t exist' % infile)
>> isolated_format.MappingError: Input file
>> D:\src\chromefetch\src\out\Release\osmesa.dll doesn't exist
>> [5731/19355] CXX obj\v8\src\heap\v8_base.heap.obj
>>
>
> I'll cleanup the error message, it's kind of ridiculous.
>
>
>  Looks like ui_touch_selection_unittests in the gyp file doesn't declare a
>> dep
>>
> on
>
>> this – if the isolate lists this, it probably should?
>>
>
> Yep.


Do you know what mesa is needed for here? `mesa file:ui/touch_sel` on
cs.chromium.org only finds the isolate entry, nothing else.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-01-24 01:11:41]

On 2015/01/24 01:01:43, Nico wrote:
> On Fri, Jan 23, 2015 at 4:04 PM, <mailto:maruel@chromium.org> wrote:
> >  Looks like ui_touch_selection_unittests in the gyp file doesn't declare a
> >> dep
> >>
> > on
> >
> >> this – if the isolate lists this, it probably should?
> >>
> >
> > Yep.
> 
> 
> Do you know what mesa is needed for here? `mesa file:ui/touch_sel` on
> http://cs.chromium.org only finds the isolate entry, nothing else.

Some opengl emulation while running under xvfb IIRC but I may be wrong.

[Nico, 2015-01-24 19:05:32]

On Fri, Jan 23, 2015 at 5:11 PM, <maruel@chromium.org> wrote:

> On 2015/01/24 01:01:43, Nico wrote:
>
>> On Fri, Jan 23, 2015 at 4:04 PM, <mailto:maruel@chromium.org> wrote:
>> >  Looks like ui_touch_selection_unittests in the gyp file doesn't
>> declare a
>> >> dep
>> >>
>> > on
>> >
>> >> this – if the isolate lists this, it probably should?
>> >>
>> >
>> > Yep.
>>
>
>
>  Do you know what mesa is needed for here? `mesa file:ui/touch_sel` on
>> http://cs.chromium.org only finds the isolate entry, nothing else.
>>
>
> Some opengl emulation while running under xvfb IIRC but I may be wrong.
>

Isn't this only needed if the .isolate file contains something like

    ['OS=="linux"', {
      'variables': {
        'command': [
          '../testing/xvfb.py',

? This file does, above, but osmesa.so is listed there. I'm asking about
osmesa.dll on Windows, and I suppose osmesa.so on Mac – why are these
needed?

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-01-26 17:17:57]

…https://codereview.chromium.org/880573002

[Marc-Antoine Ruel (Google), 2015-01-26 22:48:46]

On 2015/01/24 19:05:32, Nico wrote:
> On Fri, Jan 23, 2015 at 5:11 PM, <mailto:maruel@chromium.org> wrote:
> 
> > On 2015/01/24 01:01:43, Nico wrote:
> >  Do you know what mesa is needed for here? `mesa file:ui/touch_sel` on
> >> http://cs.chromium.org only finds the isolate entry, nothing else.
> >>
> >
> > Some opengl emulation while running under xvfb IIRC but I may be wrong.
> >
> 
> Isn't this only needed if the .isolate file contains something like
> 
>     ['OS=="linux"', {
>       'variables': {
>         'command': [
>           '../testing/xvfb.py',
> 
> ? This file does, above, but osmesa.so is listed there. I'm asking about
> osmesa.dll on Windows, and I suppose osmesa.so on Mac – why are these
> needed?

Yes

[Nico, 2015-01-26 22:50:35]

On Mon, Jan 26, 2015 at 2:48 PM, <maruel@google.com> wrote:

> On 2015/01/24 19:05:32, Nico wrote:
>
>> On Fri, Jan 23, 2015 at 5:11 PM, <mailto:maruel@chromium.org> wrote:
>>
>
>  > On 2015/01/24 01:01:43, Nico wrote:
>> >  Do you know what mesa is needed for here? `mesa file:ui/touch_sel` on
>> >> http://cs.chromium.org only finds the isolate entry, nothing else.
>> >>
>> >
>> > Some opengl emulation while running under xvfb IIRC but I may be wrong.
>> >
>>
>
>  Isn't this only needed if the .isolate file contains something like
>>
>
>       ['OS=="linux"', {
>>        'variables': {
>>          'command': [
>>            '../testing/xvfb.py',
>>
>
>  ? This file does, above, but osmesa.so is listed there. I'm asking about
>> osmesa.dll on Windows, and I suppose osmesa.so on Mac – why are these
>> needed?
>>
>
> Yes
>

Yes to which part?


>
> https://codereview.chromium.org/794903004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Marc-Antoine Ruel (Google), 2015-01-26 22:53:22]

(Clarified, sorry for the indigestible reply)

On 2015/01/26 22:50:35, Nico wrote:
> On Mon, Jan 26, 2015 at 2:48 PM, <mailto:maruel@google.com> wrote:
> 
> > On 2015/01/24 19:05:32, Nico wrote:
> >
> >> On Fri, Jan 23, 2015 at 5:11 PM, <mailto:maruel@chromium.org> wrote:
> >>
> >
> >  > On 2015/01/24 01:01:43, Nico wrote:
> >> >  Do you know what mesa is needed for here? `mesa file:ui/touch_sel` on
> >> >> http://cs.chromium.org only finds the isolate entry, nothing else.
> >> >>
> >> >
> >> > Some opengl emulation while running under xvfb IIRC but I may be wrong.
> >> >
> >>
> >
> >  Isn't this only needed if the .isolate file contains something like
> >>
> >
> >       ['OS=="linux"', {
> >>        'variables': {
> >>          'command': [
> >>            '../testing/xvfb.py',
> >>
> >
> >  ?

Yes.

> >> This file does, above, but osmesa.so is listed there. I'm asking about
> >> osmesa.dll on Windows, and I suppose osmesa.so on Mac – why are these
> >> needed?

No idea. Probably someone copy-pasted.