Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794873002: Refactor: Remove switch statements on key format from algorithm_dispatch.cc (Closed)

Created:
6 years ago by eroman
Modified:
6 years ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor: Remove switch statements on key format from algorithm_dispatch.cc Instead internalize them into AlgorithmImplementation. Committed: https://crrev.com/a22536b292e6c3d8a1eda676b67c2b8073e73245 Cr-Commit-Position: refs/heads/master@{#308042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M content/child/webcrypto/algorithm_dispatch.cc View 2 chunks +2 lines, -25 lines 0 comments Download
M content/child/webcrypto/algorithm_implementation.h View 2 chunks +13 lines, -0 lines 0 comments Download
M content/child/webcrypto/algorithm_implementation.cc View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
eroman
Minor refactor.
6 years ago (2014-12-10 22:45:32 UTC) #2
davidben
lgtm
6 years ago (2014-12-11 22:15:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794873002/1
6 years ago (2014-12-11 23:08:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/7935)
6 years ago (2014-12-12 00:59:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794873002/1
6 years ago (2014-12-12 01:26:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 03:29:36 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 03:30:21 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a22536b292e6c3d8a1eda676b67c2b8073e73245
Cr-Commit-Position: refs/heads/master@{#308042}

Powered by Google App Engine
This is Rietveld 408576698