Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 794853004: Reland 1: "mac: Allow Chrome to hand off its active URL to other devices." (Closed)

Created:
6 years ago by erikchen
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 1: "mac: Allow Chrome to hand off its active URL to other devices." The original CL used instance variables in a class extension and automatic generation of ivars for synthesized properties, features only available on 64-bit builds. The Mac Memory bots are still compiling Chromium in 32-bits. This reland removes the usage of those features. > This CL adds the class HandoffManager, which is responsible for interfacing > with Apple's Handoff APIs. It takes a GURL, and exposes that GURL to Handoff. > > This CL adds the class ActiveWebContentsObserver, which is responsible for > listening to changes to the active browser, the active tab, and the visible > URL. It notifies its delegate when any of this state might have changed. > > AppControllerMac is the delegate of ActiveWebContentsObserver, as well as the > owner of the HandoffManager. When it receives a delegate callback, it passes an > updated GURL to the HandoffManager. There is some minimal logic in > AppControllerMac that prevents URLs from incognito windows from being passed to > the HandoffManager. > > BUG=431051, 438823 > Committed: https://crrev.com/708abc5b0abb5e0916d779bf6d1342fd472a2aa1 > Cr-Commit-Position: refs/heads/master@{#307846} BUG=431051, 438823 TBR=sky, erikwright, mmenke, avi Committed: https://crrev.com/600f7962455cb8479168eb2c6678eda05365460a Cr-Commit-Position: refs/heads/master@{#308005}

Patch Set 1 : Copy of patch set 6 from original CL. #

Patch Set 2 : Rewrite parts of code that required the modern ObjC Runtime. #

Patch Set 3 : Comments from avi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -1 line) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 7 chunks +80 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 2 chunks +143 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/handoff_active_url_observer.h View 1 chunk +83 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/handoff_active_url_observer.cc View 1 chunk +124 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/handoff_active_url_observer_bridge.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/handoff_active_url_observer_bridge.mm View 1 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/handoff_active_url_observer_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/handoff.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
A + components/handoff/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/handoff/handoff_manager.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A components/handoff/handoff_manager.mm View 1 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
erikchen
On 2014/12/11 21:37:02, Avi wrote: > mailto:avi@chromium.org changed reviewers: > + mailto:avi@chromium.org AppEngine is having ...
6 years ago (2014-12-11 21:40:43 UTC) #6
erikchen
On 2014/12/11 21:40:43, erikchen wrote: > On 2014/12/11 21:37:02, Avi wrote: > > mailto:avi@chromium.org changed ...
6 years ago (2014-12-11 21:44:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794853004/80001
6 years ago (2014-12-11 23:08:47 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years ago (2014-12-12 00:17:45 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 00:19:18 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/600f7962455cb8479168eb2c6678eda05365460a
Cr-Commit-Position: refs/heads/master@{#308005}

Powered by Google App Engine
This is Rietveld 408576698