Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Issue 794673007: Added unit tests for the GPU Tracer. (Closed)

Created:
6 years ago by David Yen
Modified:
5 years, 11 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added unit tests for the GPU Tracer. There had previously only had unit tests for the each GPUTrace but none for the GPUTracer itself. This CL virtualizes various parts of the GPUTracer so that it can be properly tested. BUG=None TEST=trybots Committed: https://crrev.com/75755fafa44d82854d5beece5149ff6de22d0d2d Cr-Commit-Position: refs/heads/master@{#310398}

Patch Set 1 #

Patch Set 2 : Added Tracer GL Mock tests #

Patch Set 3 : Added tests for disjoint tracer #

Patch Set 4 : Reverted gpu_service_test #

Total comments: 4

Patch Set 5 : Removed c++11 usage of std::to_string #

Patch Set 6 : Utilize mock decoder #

Patch Set 7 : Fixed chromium-style issues #

Patch Set 8 : Removed redundant virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -98 lines) Patch
M gpu/command_buffer/service/gpu_tracer.h View 1 8 chunks +52 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 1 2 3 4 5 13 chunks +83 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 2 3 4 5 6 7 7 chunks +534 lines, -63 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
David Yen
Brought over unit tests changes to this CL from here: https://codereview.chromium.org/813573003/ I finished restructuring the ...
5 years, 11 months ago (2015-01-06 22:40:00 UTC) #2
vmiura
Looks good. https://codereview.chromium.org/794673007/diff/60001/gpu/command_buffer/service/gpu_tracer.cc File gpu/command_buffer/service/gpu_tracer.cc (right): https://codereview.chromium.org/794673007/diff/60001/gpu/command_buffer/service/gpu_tracer.cc#newcode75 gpu/command_buffer/service/gpu_tracer.cc:75: TRACE_EVENT_COPY_ASYNC_BEGIN0(category.c_str(), name.c_str(), id); Using dynamic category strings ...
5 years, 11 months ago (2015-01-07 00:40:56 UTC) #3
David Yen
https://codereview.chromium.org/794673007/diff/60001/gpu/command_buffer/service/gpu_tracer.cc File gpu/command_buffer/service/gpu_tracer.cc (right): https://codereview.chromium.org/794673007/diff/60001/gpu/command_buffer/service/gpu_tracer.cc#newcode75 gpu/command_buffer/service/gpu_tracer.cc:75: TRACE_EVENT_COPY_ASYNC_BEGIN0(category.c_str(), name.c_str(), id); On 2015/01/07 00:40:56, vmiura wrote: > ...
5 years, 11 months ago (2015-01-07 18:11:48 UTC) #4
vmiura
LGTM.
5 years, 11 months ago (2015-01-07 22:24:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794673007/130001
5 years, 11 months ago (2015-01-07 22:26:45 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 11 months ago (2015-01-07 22:55:38 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 22:56:24 UTC) #9
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/75755fafa44d82854d5beece5149ff6de22d0d2d
Cr-Commit-Position: refs/heads/master@{#310398}

Powered by Google App Engine
This is Rietveld 408576698