Issue 794663002: Revert of Avoid number range holes in bitset types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794663002: Revert of Avoid number range holes in bitset types. (Closed)

Created:
6 years ago by Jarin

Modified:
6 years ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert of Avoid number range holes in bitset types. (patchset #5 id:80001 of https://codereview.chromium.org/759013003/) Reason for revert: For breaking the waterfall (run-json-stringify test). Original issue's description: > Avoid number range holes in bitset types. > > BUG= TBR=rossberg@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -171 lines)			Patch
M	src/compiler/typer.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	src/types.h	View	4 chunks	+50 lines, -71 lines	0 comments	Download
M	src/types.cc	View	3 chunks	+18 lines, -22 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	3 chunks	+18 lines, -22 lines	0 comments	Download
M	test/cctest/test-types.cc	View	2 chunks	+27 lines, -43 lines	0 comments	Download
M	test/cctest/types-fuzz.h	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	test/unittests/compiler/js-builtin-reducer-unittest.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794663002/1

6 years ago (2014-12-10 18:25:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages