Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 794643002: Remove mods-since-v0_4_0.diff from third_party/libjingle (Closed)

Created:
6 years ago by Sergey Ulanov
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove mods-since-v0_4_0.diff from third_party/libjingle The patch was useful only when we had forked version of libjingle checked in in chromium, which hasn't been the case for very long time. TBR=hclam@chromium.org Committed: https://crrev.com/304f63b80f9803e28b68a1a9c09fbe5fd238cacd Cr-Commit-Position: refs/heads/master@{#308129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1684 lines) Patch
D third_party/libjingle/mods-since-v0_4_0.diff View 1 chunk +0 lines, -1684 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sergey Ulanov
6 years ago (2014-12-10 17:41:39 UTC) #2
hellner1
lgtm
6 years ago (2014-12-12 17:15:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794643002/1
6 years ago (2014-12-12 17:27:41 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-12 17:27:44 UTC) #7
Sergey Ulanov
+hclam@ in TBR
6 years ago (2014-12-12 17:31:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794643002/1
6 years ago (2014-12-12 17:32:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 18:45:14 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-12 18:46:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/304f63b80f9803e28b68a1a9c09fbe5fd238cacd
Cr-Commit-Position: refs/heads/master@{#308129}

Powered by Google App Engine
This is Rietveld 408576698