Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9466)

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions_unittest.cc
diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4089bbe9949c889bd296f014c08780202da98f61
--- /dev/null
+++ b/content/child/notifications/notification_data_conversions_unittest.cc
@@ -0,0 +1,97 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/child/notifications/notification_data_conversions.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "content/public/common/platform_notification_data.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebNotificationData.h"
+#include "third_party/WebKit/public/platform/WebString.h"
+#include "third_party/WebKit/public/platform/WebURL.h"
+
+namespace content {
+namespace {
+
+const char kNotificationTitle[] = "My Notification";
+const char kNotificationLang[] = "nl";
+const char kNotificationBody[] = "Hello, world!";
+const char kNotificationTag[] = "my_tag";
+const char kNotificationIconUrl[] = "https://example.com/icon.png";
+
+}
+
+TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
+ blink::WebNotificationData web_data(
+ blink::WebString::fromUTF8(kNotificationTitle),
+ blink::WebNotificationData::DirectionLeftToRight,
+ blink::WebString::fromUTF8(kNotificationLang),
+ blink::WebString::fromUTF8(kNotificationBody),
+ blink::WebString::fromUTF8(kNotificationTag),
+ blink::WebURL(GURL(kNotificationIconUrl)));
+
+ PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
+ EXPECT_EQ(base::ASCIIToUTF16(kNotificationTitle), platform_data.title);
+ EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight,
+ platform_data.direction);
+ EXPECT_EQ(kNotificationLang, platform_data.lang);
+ EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body);
+ EXPECT_EQ(base::ASCIIToUTF16(kNotificationTag), platform_data.tag);
+ EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
+}
+
+TEST(NotificationDataConversionsTest,
+ ToPlatformNotificationDataDirectionality) {
+ blink::WebNotificationData web_data;
+ web_data.direction = blink::WebNotificationData::DirectionLeftToRight;
+
+ PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
+ EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight,
+ platform_data.direction);
+
+ web_data.direction = blink::WebNotificationData::DirectionRightToLeft;
+
+ platform_data = ToPlatformNotificationData(web_data);
+ EXPECT_EQ(PlatformNotificationData::NotificationDirectionRightToLeft,
+ platform_data.direction);
+}
+
+TEST(NotificationDataConversionsTest, ToWebNotificationData) {
+ PlatformNotificationData platform_data;
+ platform_data.title = base::ASCIIToUTF16(kNotificationTitle);
+ platform_data.direction =
+ PlatformNotificationData::NotificationDirectionLeftToRight;
+ platform_data.lang = kNotificationLang;
+ platform_data.body = base::ASCIIToUTF16(kNotificationBody);
+ platform_data.tag = base::ASCIIToUTF16(kNotificationTag);
+ platform_data.icon = GURL(kNotificationIconUrl);
+
+ blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
+ EXPECT_EQ(kNotificationTitle, web_data.title);
+ EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight,
+ web_data.direction);
+ EXPECT_EQ(kNotificationLang, web_data.lang);
+ EXPECT_EQ(kNotificationBody, web_data.body);
+ EXPECT_EQ(kNotificationTag, web_data.tag);
+ EXPECT_EQ(kNotificationIconUrl, web_data.icon.string());
+}
+
+TEST(NotificationDataConversionsTest, ToWebNotificationDataDirectionality) {
+ PlatformNotificationData platform_data;
+ platform_data.direction =
+ PlatformNotificationData::NotificationDirectionLeftToRight;
+
+ blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
+ EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight,
+ web_data.direction);
+
+ platform_data.direction =
+ PlatformNotificationData::NotificationDirectionRightToLeft;
+
+ web_data = ToWebNotificationData(platform_data);
+ EXPECT_EQ(blink::WebNotificationData::DirectionRightToLeft,
+ web_data.direction);
+}
+
+} // namespace content
« no previous file with comments | « content/child/notifications/notification_data_conversions.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698