content/browser/service_worker/service_worker_version.cc - Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/child/notifications/notification_data_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 4f05ec96baedb2ace60cabd54b048a4c06af3e72..b4a9e72931ee66bae12f2dd338f68b0c27ae0d44 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -460,7 +460,7 @@ void ServiceWorkerVersion::DispatchSyncEvent(const StatusCallback& callback) {

void ServiceWorkerVersion::DispatchNotificationClickEvent(

const StatusCallback& callback,

const std::string& notification_id,

- const ShowDesktopNotificationHostMsgParams& notification_data) {

+ const PlatformNotificationData& notification_data) {

DCHECK_EQ(ACTIVATED, status()) << status();

if (!CommandLine::ForCurrentProcess()->HasSwitch(