content/browser/notifications/notification_message_filter.h - Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.h

Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_event_dispatcher_impl.cc ('k') | content/browser/notifications/notification_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_message_filter.h

diff --git a/content/browser/notifications/notification_message_filter.h b/content/browser/notifications/notification_message_filter.h

index 82bd8876ad5cdf40f68ac41737b49b60a0d84955..44e9c8122a4a3201abb53372f5a908615b10b379 100644

--- a/content/browser/notifications/notification_message_filter.h

+++ b/content/browser/notifications/notification_message_filter.h

@@ -12,12 +12,13 @@

#include "third_party/WebKit/public/platform/WebNotificationPermission.h"

class GURL;

+class SkBitmap;

namespace content {

class BrowserContext;

+struct PlatformNotificationData;

class ResourceContext;

-struct ShowDesktopNotificationHostMsgParams;

class NotificationMessageFilter : public BrowserMessageFilter {

public:

@@ -42,11 +43,16 @@ class NotificationMessageFilter : public BrowserMessageFilter {

void OnCheckNotificationPermission(

const GURL& origin, blink::WebNotificationPermission* permission);

void OnShowPlatformNotification(

- int notification_id, const ShowDesktopNotificationHostMsgParams& params);

+ int notification_id,

+ const GURL& origin,

+ const SkBitmap& icon,

+ const PlatformNotificationData& notification_data);

void OnShowPersistentNotification(

int request_id,

int64 service_worker_registration_id,

- const ShowDesktopNotificationHostMsgParams& params);

+ const GURL& origin,

+ const SkBitmap& icon,

+ const PlatformNotificationData& notification_data);

void OnClosePlatformNotification(int notification_id);

void OnClosePersistentNotification(

const std::string& persistent_notification_id);