Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index 9a801cfc952811771a0d33af0c87dc4645f7cdaf..d3e36d285b6e1fd8e22f896ea376167a82b70c9b 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -7,6 +7,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/singleton.h"
+#include "base/strings/string16.h"
#include "content/public/browser/platform_notification_service.h"
class NotificationUIManager;
@@ -29,17 +30,21 @@ class PlatformNotificationServiceImpl
blink::WebNotificationPermission CheckPermission(
content::ResourceContext* resource_context,
const GURL& origin,
- int render_process_id) override;;
+ int render_process_id) override;
void DisplayNotification(
content::BrowserContext* browser_context,
- const content::ShowDesktopNotificationHostMsgParams& params,
+ const GURL& origin,
+ const SkBitmap& icon,
+ const content::PlatformNotificationData& notification_data,
scoped_ptr<content::DesktopNotificationDelegate> delegate,
int render_process_id,
base::Closure* cancel_callback) override;
void DisplayPersistentNotification(
content::BrowserContext* browser_context,
int64 service_worker_registration_id,
- const content::ShowDesktopNotificationHostMsgParams& params,
+ const GURL& origin,
+ const SkBitmap& icon,
+ const content::PlatformNotificationData& notification_data,
int render_process_id) override;
void ClosePersistentNotification(
content::BrowserContext* browser_context,

Powered by Google App Engine
This is Rietveld 408576698