Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/public/browser/platform_notification_service.h

Issue 794633002: Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/platform_notification_service.h
diff --git a/content/public/browser/platform_notification_service.h b/content/public/browser/platform_notification_service.h
index 65729b8998917776d2a6583dd998fe00c35fad0f..26536e616b28090987e0c8666d8723c2a7507e69 100644
--- a/content/public/browser/platform_notification_service.h
+++ b/content/public/browser/platform_notification_service.h
@@ -10,15 +10,16 @@
#include "base/callback_forward.h"
#include "base/memory/scoped_ptr.h"
#include "content/common/content_export.h"
-#include "content/public/common/show_desktop_notification_params.h"
#include "third_party/WebKit/public/platform/WebNotificationPermission.h"
class GURL;
+class SkBitmap;
namespace content {
class BrowserContext;
class DesktopNotificationDelegate;
+struct PlatformNotificationData;
class ResourceContext;
// The service using which notifications can be presented to the user. There
@@ -40,7 +41,9 @@ class CONTENT_EXPORT PlatformNotificationService {
// |cancel_callback| argument. This method must be called on the UI thread.
virtual void DisplayNotification(
BrowserContext* browser_context,
- const ShowDesktopNotificationHostMsgParams& params,
+ const GURL& origin,
+ const SkBitmap& icon,
+ const PlatformNotificationData& notification_data,
scoped_ptr<DesktopNotificationDelegate> delegate,
int render_process_id,
base::Closure* cancel_callback) = 0;
@@ -50,7 +53,9 @@ class CONTENT_EXPORT PlatformNotificationService {
virtual void DisplayPersistentNotification(
BrowserContext* browser_context,
int64 service_worker_registration_id,
- const ShowDesktopNotificationHostMsgParams& params,
+ const GURL& origin,
+ const SkBitmap& icon,
+ const PlatformNotificationData& notification_data,
int render_process_id) = 0;
// Closes the persistent notification identified by

Powered by Google App Engine
This is Rietveld 408576698