Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 7946013: Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*. (Closed)

Created:
7 years, 9 months ago by levin
Modified:
7 years, 9 months ago
Reviewers:
levin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*. https://bugs.webkit.org/show_bug.cgi?id=67947 Reviewed by Adam Barth. The changes are tested by compiling and added compile asserts to do some verification as well. * platform/CrossThreadCopier.cpp: Added some compile asserts to verify various match and non-matches for CrossThreadCopier. * platform/CrossThreadCopier.h: Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr. Added a compile assert to verify that only one of the typedefs did anything. (CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary. It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method. TBR=levin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -2 lines) Patch
M Source/WebCore/platform/CrossThreadCopier.h View 3 chunks +12 lines, -2 lines 0 comments Download
M Source/WebCore/platform/CrossThreadCopier.cpp View 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
levin
7 years, 9 months ago (2011-09-19 20:19:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698