tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py - Issue 794583004: Reland of Migrate DeviceUtils.ReadFile to adb_wrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py

Issue 794583004: Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: command line file should be read as_root Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py ('k') | tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py

index 0b4c2a6c1e07f9552f69822eddbd0b66a0e578f8..ea283ac432d8b65d74b1e3d2351a9d9888acc472 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py

@@ -61,7 +61,7 @@ class AndroidTemperatureMonitorTest(unittest.TestCase):

mock_power_monitor.ExpectCall('CanMonitorPower').WillReturn(False)

mock_adb = simple_mock.MockObject()

mock_device_utils = simple_mock.MockObject()

- mock_device_utils.ExpectCall('ReadFile', _).WillReturn([])

+ mock_device_utils.ExpectCall('ReadFile', _).WillReturn('')

setattr(mock_device_utils, 'old_interface', mock_adb)

monitor = android_temperature_monitor.AndroidTemperatureMonitor(