tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py - Issue 794583004: Reland of Migrate DeviceUtils.ReadFile to adb_wrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py

Issue 794583004: Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: command line file should be read as_root Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py

index c103026f2facddbbb241276a5cf9b2b1bd9b81f8..2658d1e05111f1ae78970df5d65735c72eb9f7f7 100644

--- a/tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py

@@ -27,12 +27,12 @@ class AndroidPlatformBackendTest(unittest.TestCase):

@benchmark.Disabled('chromeos')

def testGetCpuStats(self):

- proc_stat_content = [

+ proc_stat_content = (

'7702 (.android.chrome) S 167 167 0 0 -1 1077936448 '

'3247 0 0 0 4 1 0 0 20 0 9 0 5603962 337379328 5867 '

'4294967295 1074458624 1074463824 3197495984 3197494152 '

'1074767676 0 4612 0 38136 4294967295 0 0 17 0 0 0 0 0 0 '

- '1074470376 1074470912 1102155776']

+ '1074470376 1074470912 1102155776\n')

self._stubs.adb_commands.adb_device.mock_content = proc_stat_content

old_interface = self._stubs.adb_commands.adb_device.old_interface

old_interface.can_access_protected_file_contents = True