Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/test/nacl/nacl_browsertest_util.h

Issue 794573002: Enable transitional non-SFI browser tests on ARM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: leave MAYBE_PNACL_TRANSITIONAL_NONSFI Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.isolate ('k') | components/nacl_nonsfi.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/nacl_browsertest_util.h
diff --git a/chrome/test/nacl/nacl_browsertest_util.h b/chrome/test/nacl/nacl_browsertest_util.h
index 289a339e83add37f6a60b77514a4989c82a7e79d..8a922244a3e2b327adb355e81f9e3bd2e375cf51 100644
--- a/chrome/test/nacl/nacl_browsertest_util.h
+++ b/chrome/test/nacl/nacl_browsertest_util.h
@@ -200,11 +200,12 @@ class NaClBrowserTestGLibcExtension : public NaClBrowserTestGLibc {
# define MAYBE_NONSFI(test_case) DISABLED_##test_case
#endif
-// Currently, we only support it on x86-32 architecture.
-// TODO(hidehiko,mazda): Enable this on ARM, too, when it is supported.
+// Currently, we only support it on x86-32 or ARM architecture.
+// TODO(hidehiko,mazda): Enable this on x86-64, too, when it is supported.
#if defined(OS_LINUX) && !defined(ADDRESS_SANITIZER) && \
!defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && \
- !defined(LEAK_SANITIZER) && defined(ARCH_CPU_X86)
+ !defined(LEAK_SANITIZER) && \
+ (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL))
# define MAYBE_TRANSITIONAL_NONSFI(test_case) test_case
#else
# define MAYBE_TRANSITIONAL_NONSFI(test_case) DISABLED_##test_case
@@ -218,10 +219,11 @@ class NaClBrowserTestGLibcExtension : public NaClBrowserTestGLibc {
# define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
#endif
-// Similar to MAYBE_NACL_HELPER_NONSFI, this is not available on ARM yet.
+// Similar to MAYBE_TRANSITIONAL_NONSFI, this is available only on x86-32 or
+// ARM.
// TODO(hidehiko,mazda): Merge this to the MAYBE_PNACL_NONSFI when it is
-// supported on ARM.
-#if defined(OS_LINUX) && defined(ARCH_CPU_X86)
+// supported on x86-64.
+#if defined(OS_LINUX) && (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL))
# define MAYBE_PNACL_TRANSITIONAL_NONSFI(test_case) test_case
#else
# define MAYBE_PNACL_TRANSITIONAL_NONSFI(test_case) DISABLED_##test_case
« no previous file with comments | « chrome/chrome.isolate ('k') | components/nacl_nonsfi.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698