Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: net/socket/ssl_client_socket.cc

Issue 794563003: Change next_proto member type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit in comment. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket.h ('k') | net/socket/ssl_client_socket_openssl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket.cc
diff --git a/net/socket/ssl_client_socket.cc b/net/socket/ssl_client_socket.cc
index a52e6a3c052c70eba239aa57594c8a390816fc56..f6b9b895fa853410be2c8ed7d6fb9a3ff39ab726 100644
--- a/net/socket/ssl_client_socket.cc
+++ b/net/socket/ssl_client_socket.cc
@@ -235,34 +235,34 @@ bool SSLClientSocket::IsChannelIDEnabled(
// static
std::vector<uint8_t> SSLClientSocket::SerializeNextProtos(
- const std::vector<std::string>& next_protos) {
+ const NextProtoVector& next_protos) {
// Do a first pass to determine the total length.
size_t wire_length = 0;
- for (std::vector<std::string>::const_iterator i = next_protos.begin();
- i != next_protos.end(); ++i) {
- if (i->size() > 255) {
- LOG(WARNING) << "Ignoring overlong NPN/ALPN protocol: " << *i;
+ std::vector<std::string> next_proto_strings;
+ for (const NextProto next_proto : next_protos) {
+ const std::string proto = NextProtoToString(next_proto);
+ if (proto.size() > 255) {
+ LOG(WARNING) << "Ignoring overlong NPN/ALPN protocol: " << proto;
continue;
}
- if (i->size() == 0) {
+ if (proto.size() == 0) {
LOG(WARNING) << "Ignoring empty NPN/ALPN protocol";
continue;
}
- wire_length += i->size();
+ next_proto_strings.push_back(proto);
+ wire_length += proto.size();
wire_length++;
}
// Allocate memory for the result and fill it in.
std::vector<uint8_t> wire_protos;
wire_protos.reserve(wire_length);
- for (std::vector<std::string>::const_iterator i = next_protos.begin();
- i != next_protos.end(); i++) {
- if (i->size() == 0 || i->size() > 255)
- continue;
- wire_protos.push_back(i->size());
- wire_protos.resize(wire_protos.size() + i->size());
- memcpy(&wire_protos[wire_protos.size() - i->size()],
- i->data(), i->size());
+ for (const std::string& proto : next_proto_strings) {
+ wire_protos.push_back(proto.size());
+ // TODO(bnc): Rewrite.
+ wire_protos.resize(wire_protos.size() + proto.size());
+ memcpy(&wire_protos[wire_protos.size() - proto.size()], proto.data(),
+ proto.size());
}
DCHECK_EQ(wire_protos.size(), wire_length);
« no previous file with comments | « net/socket/ssl_client_socket.h ('k') | net/socket/ssl_client_socket_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698