Change next_proto member type.

net/base/net_log_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_log_util.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 15 matching lines @@
 #include "net/dns/host_resolver.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_server_properties.h"
 #include "net/http/http_transaction_factory.h"
 #include "net/proxy/proxy_config.h"
 #include "net/proxy/proxy_retry_info.h"
 #include "net/proxy/proxy_service.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_utils.h"
+#include "net/socket/ssl_client_socket.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 
 namespace net {
 
 namespace {
 
 // This should be incremented when significant changes are made that will
 // invalidate the old loading code.
 const int kLogFormatVersion = 1;
@@ skipping 394 matching lines @@
     status_dict->SetBoolean(
         "use_alternate_protocols",
         http_network_session->params().use_alternate_protocols);
     status_dict->SetBoolean(
         "force_spdy_over_ssl",
         http_network_session->params().force_spdy_over_ssl);
     status_dict->SetBoolean(
         "force_spdy_always",
         http_network_session->params().force_spdy_always);
 
-    std::vector<std::string> next_protos;
+    NextProtoVector next_protos;
     http_network_session->GetNextProtos(&next_protos);
-    std::string next_protos_string = JoinString(next_protos, ',');
-    status_dict->SetString("next_protos", next_protos_string);
+    if (!next_protos.empty()) {
+      NextProtoVector::iterator it = next_protos.begin();
+      std::string next_protos_string(SSLClientSocket::NextProtoToString(*it));
+      ++it;
+      for (; it != next_protos.end(); ++it) {
+        next_protos_string.append(",");
+        next_protos_string.append(SSLClientSocket::NextProtoToString(*it));
+      }

[Ryan Hamilton, 2014/12/10 20:08:59]

How about:

std::string next_protos_string;
for (const NextProto proto : next_protos) {
  if (!next_protos_string.empty()) 
    next_protos_string.append(",")'

  next_protos_string.append(SSLClientSocket::NextProtoToString(proto));
}

[Bence, 2014/12/10 22:01:23]

Done.

+      status_dict->SetString("next_protos", next_protos_string);

[Ryan Hamilton, 2014/12/10 20:09:00]

Alternatively, you could consider using a ListValue instead of a comma separated
string.

+    }
 
     net_info_dict->Set(NetInfoSourceToString(NET_INFO_SPDY_STATUS),
                         status_dict);
   }
 
   if (info_sources & NET_INFO_SPDY_ALT_PROTO_MAPPINGS) {
     base::ListValue* dict_list = new base::ListValue();
 
     const net::HttpServerProperties& http_server_properties =
         *context->http_server_properties();
@@ skipping 84 matching lines @@
                                       request->net_log().source(),
                                       net::NetLog::PHASE_BEGIN,
                                       request->creation_time(),
                                       &callback);
     NetLog::Entry entry(&entry_data, request->net_log().GetLogLevel());
     observer->OnAddEntry(entry);
   }
 }
 
 }  // namespace net