Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 794563002: fix gcmole warning after r25737 (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

fix gcmole warning after r25737 TBR=jkummerow@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/objects-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794563002/1
6 years ago (2014-12-10 11:38:45 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-10 11:38:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794563002/1
6 years ago (2014-12-10 11:45:45 UTC) #7
Jakob Kummerow
LGTM, although I would have preferred s/auto/Handle<Foreign>/. I see no reason not to be explicit.
6 years ago (2014-12-10 11:54:02 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-10 12:14:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698