Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 794513002: Return boolean value for bool return type functions. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Return boolean value for bool return type functions. Currently in some of the function which returns a bool, are returning int, which would be getting casted to boolean. So, to eliminate the casting better return a boolean for bool return type functions. NOTE: This change also removes the math element role. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M Source/modules/accessibility/AXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 26 chunks +26 lines, -26 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-12-10 06:10:30 UTC) #2
dmazzoni
lgtm
6 years ago (2014-12-10 18:43:29 UTC) #4
dmazzoni
This change also removes the math element role, which is fine - but please include ...
6 years ago (2014-12-10 18:43:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794513002/1
6 years ago (2014-12-10 18:56:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/21901)
6 years ago (2014-12-10 19:59:21 UTC) #9
shreeramk
On 2014/12/10 19:59:21, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-11 02:54:44 UTC) #10
Mike West
LGTM. Sorry for the delay; I was out sick most of last week.
6 years ago (2014-12-15 08:44:36 UTC) #11
shreeramk
On 2014/12/15 08:44:36, Mike West wrote: > LGTM. Sorry for the delay; I was out ...
6 years ago (2014-12-15 09:16:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794513002/1
6 years ago (2014-12-15 09:17:11 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-15 10:54:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187127

Powered by Google App Engine
This is Rietveld 408576698