Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

Issue 794493004: Refactor downloading archives in archive_info.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
index 30f54f199a01aae689501778135e4623e635abce..48fb49541028311dbcfb2edbe8bd88542ef634cb 100644
--- a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
@@ -408,12 +408,12 @@ class UserStoryRunnerTest(unittest.TestCase):
finally:
sys.stdout = real_stdout
- def testCheckArchives(self):
+ def testUpdateAndCheckArchives(self):
uss = user_story_set.UserStorySet()
uss.AddUserStory(page_module.Page(
'http://www.testurl.com', uss, uss.base_dir))
# Page set missing archive_data_file.
- self.assertFalse(user_story_runner._CheckArchives(
+ self.assertFalse(user_story_runner._UpdateAndCheckArchives(
uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
uss = user_story_set.UserStorySet(
@@ -421,7 +421,7 @@ class UserStoryRunnerTest(unittest.TestCase):
uss.AddUserStory(page_module.Page(
'http://www.testurl.com', uss, uss.base_dir))
# Page set missing json file specified in archive_data_file.
- self.assertFalse(user_story_runner._CheckArchives(
+ self.assertFalse(user_story_runner._UpdateAndCheckArchives(
uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
uss = user_story_set.UserStorySet(
@@ -430,12 +430,12 @@ class UserStoryRunnerTest(unittest.TestCase):
uss.AddUserStory(page_module.Page(
'http://www.testurl.com', uss, uss.base_dir))
# Page set with valid archive_data_file.
- self.assertTrue(user_story_runner._CheckArchives(
+ self.assertTrue(user_story_runner._UpdateAndCheckArchives(
uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
uss.AddUserStory(page_module.Page(
'http://www.google.com', uss, uss.base_dir))
# Page set with an archive_data_file which exists but is missing a page.
- self.assertFalse(user_story_runner._CheckArchives(
+ self.assertFalse(user_story_runner._UpdateAndCheckArchives(
uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
uss = user_story_set.UserStorySet(
@@ -447,7 +447,7 @@ class UserStoryRunnerTest(unittest.TestCase):
'http://www.google.com', uss, uss.base_dir))
# Page set with an archive_data_file which exists and contains all pages
# but fails to find a wpr file.
- self.assertFalse(user_story_runner._CheckArchives(
+ self.assertFalse(user_story_runner._UpdateAndCheckArchives(
uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | tools/telemetry/telemetry/wpr/archive_info.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698