Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9092)

Unified Diff: components/metrics/histogram_manager_unittest.cc

Issue 794493002: Add UMA Histogram Manager to Cronet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved histogram_manager_unittest to components/metrics Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/histogram_manager_unittest.cc
diff --git a/components/metrics/histogram_manager_unittest.cc b/components/metrics/histogram_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2b7baf817d99fbf951adbb7dc112899a9c774653
--- /dev/null
+++ b/components/metrics/histogram_manager_unittest.cc
@@ -0,0 +1,52 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/histogram_manager.h"
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace metrics {
+
+// TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.*
+// files into components/android/cronet.
+TEST(HistogramManager, HistogramBucketFields) {
+ // kNoFlags filter should record all histograms.
+ UMA_HISTOGRAM_ENUMERATION("UmaHistogram", 1, 2);
+
+ std::vector<uint8> data = HistogramManager::GetInstance()->GetDeltas();
+ EXPECT_LT(0u, data.size());
+ ChromeUserMetricsExtension uma_proto;
+ EXPECT_TRUE(uma_proto.ParseFromArray(data.data(), data.size()));
+ EXPECT_LT(0u, data.size());
+
+ const HistogramEventProto& histogram_proto =
+ uma_proto.histogram_event(uma_proto.histogram_event_size() - 1);
+ ASSERT_EQ(1, histogram_proto.bucket_size());
+ EXPECT_FALSE(histogram_proto.bucket(0).has_min());
+ EXPECT_TRUE(histogram_proto.bucket(0).has_max());
+ EXPECT_EQ(0, histogram_proto.bucket(0).min());
+ EXPECT_EQ(2, histogram_proto.bucket(0).max());
+ EXPECT_EQ(1, histogram_proto.bucket(0).count());
+
+ UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 2, 3);
+ std::vector<uint8> data2 = HistogramManager::GetInstance()->GetDeltas();
+ EXPECT_LT(0u, data2.size());
+ ChromeUserMetricsExtension uma_proto2;
+ EXPECT_TRUE(uma_proto2.ParseFromArray(data2.data(), data2.size()));
+ EXPECT_LT(0u, data2.size());
+
+ const HistogramEventProto& histogram_proto2 =
+ uma_proto2.histogram_event(uma_proto2.histogram_event_size() - 1);
+ ASSERT_EQ(1, histogram_proto2.bucket_size());
+ EXPECT_FALSE(histogram_proto2.bucket(0).has_min());
+ EXPECT_TRUE(histogram_proto2.bucket(0).has_max());
+ EXPECT_EQ(0, histogram_proto2.bucket(0).min());
+ EXPECT_EQ(3, histogram_proto2.bucket(0).max());
+ EXPECT_EQ(1, histogram_proto2.bucket(0).count());
+}
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698