Issue 794473003: Revert of [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794473003: Revert of [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer. (patchset #1 id:1 of https://codereview.chromium.org/801263002/) Reason for revert: Can cause reduce cycles, needs more investigation Original issue's description: > [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer. > > TEST=unittests > R=svenpanne@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/6e7ceee4d02a81f167d47d8c6dc57a226b8d98d4 TBR=svenpanne@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5a8be47d21f3abc857b26c4febf5255d936ba3b9 Cr-Commit-Position: refs/heads/master@{#25859}

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -64 lines)			Patch
M	src/compiler/machine-operator-reducer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View	1 chunk	+23 lines, -44 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Created Revert of [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer.

6 years ago (2014-12-17 09:50:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794473003/1

6 years ago (2014-12-17 09:51:02 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-17 10:14:49 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5a8be47d21f3abc857b26c4febf5255d936ba3b9
Cr-Commit-Position: refs/heads/master@{#25859}