tools/telemetry/telemetry/wpr/archive_info.py - Issue 794363005: Revert of Revert of [Telemetry] Fix WPR files not being downloaded when required.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/wpr/archive_info.py

Issue 794363005: Revert of Revert of [Telemetry] Fix WPR files not being downloaded when required. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/unittest_util/system_stub.py ('k') | tools/telemetry/telemetry/wpr/archive_info_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/wpr/archive_info.py

diff --git a/tools/telemetry/telemetry/wpr/archive_info.py b/tools/telemetry/telemetry/wpr/archive_info.py

index c94bd7ba6f6117f1a295484ed4df843cf52115e2..2cf54823da51cbf062ae9ac109a8dad5189b1680 100644

--- a/tools/telemetry/telemetry/wpr/archive_info.py

+++ b/tools/telemetry/telemetry/wpr/archive_info.py

@@ -73,12 +73,9 @@

exists.

"""

# Download all .wpr files.

- if self._data:

- return

if not self._bucket:

logging.warning('User story set in %s has no bucket specified, and '

'cannot be downloaded from cloud_storage.', )

for archive_path in self._data['archives']:

archive_path = self._WprFileNameToPath(archive_path)

try:

« no previous file with comments | « tools/telemetry/telemetry/unittest_util/system_stub.py ('k') | tools/telemetry/telemetry/wpr/archive_info_unittest.py » ('j') | no next file with comments »