Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 794333003: virtual/override specifier cleanup in content/. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
dcheng, nasko
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-content_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

virtual/override specifier cleanup in content/. These are changes detected by Chromecast not covered by the Linux build. See: https://codereview.chromium.org/831863003 R=nasko@chromium.org BUG=417463 Committed: https://crrev.com/5b7b77c964fbc852de546303428622029a0fd636 Cr-Commit-Position: refs/heads/master@{#309997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M content/browser/compositor/overlay_candidate_validator_ozone.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/empty_wifi_data_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/renderer_cdm_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
gunsch
5 years, 11 months ago (2015-01-05 21:23:18 UTC) #1
nasko
Adding dcheng@ for visibility, as he's been doing this conversion for a while now. LGTM
5 years, 11 months ago (2015-01-05 21:37:55 UTC) #3
dcheng
What GYP_DEFINES gate this code? I'm happy to adapt build/common.gypi to make the rollout more ...
5 years, 11 months ago (2015-01-05 21:40:51 UTC) #4
gunsch
On 2015/01/05 21:40:51, dcheng wrote: > What GYP_DEFINES gate this code? I'm happy to adapt ...
5 years, 11 months ago (2015-01-05 21:52:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794333003/1
5 years, 11 months ago (2015-01-05 21:54:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-05 23:42:26 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 23:43:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b7b77c964fbc852de546303428622029a0fd636
Cr-Commit-Position: refs/heads/master@{#309997}

Powered by Google App Engine
This is Rietveld 408576698