Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 794323006: Re-upload - Fix crash when we don't have a plane to display (Closed)

Created:
6 years ago by achaulk
Modified:
6 years ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-upload - Fix crash when we don't have a plane to display Committed: https://crrev.com/a58e37219a76ecc461ab4a97e89ca63ad630bd61 Cr-Commit-Position: refs/heads/master@{#308364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M ui/ozone/platform/dri/crtc_controller.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/overlay_plane.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/overlay_plane.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
achaulk
Now 100% more buildable!
6 years ago (2014-12-12 20:23:51 UTC) #2
dnicoara
lgtm ... but you should probably run the Ozone bots to prove it to the ...
6 years ago (2014-12-12 20:26:57 UTC) #3
achaulk
Maybe we should get them to be included in the default set...
6 years ago (2014-12-12 20:27:41 UTC) #4
spang
On 2014/12/12 20:27:41, achaulk wrote: > Maybe we should get them to be included in ...
6 years ago (2014-12-12 20:46:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794323006/1
6 years ago (2014-12-15 16:18:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 17:08:44 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-15 17:09:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a58e37219a76ecc461ab4a97e89ca63ad630bd61
Cr-Commit-Position: refs/heads/master@{#308364}

Powered by Google App Engine
This is Rietveld 408576698