Source/platform/graphics/paint/DrawingRecorder.cpp - Issue 794323004: Emit dummy display item when recorded picture is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/paint/DrawingRecorder.cpp

Issue 794323004: Emit dummy display item when recorded picture is empty (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a missed "override" Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/paint/DrawingRecorder.cpp

diff --git a/Source/platform/graphics/paint/DrawingRecorder.cpp b/Source/platform/graphics/paint/DrawingRecorder.cpp

index 81bdef4c78d1695e12f6bd2577ba64c11e9f4c11..d5d2f61fa6fab2af397330f1ef36f0b1b8d1c8ce 100644

--- a/Source/platform/graphics/paint/DrawingRecorder.cpp

+++ b/Source/platform/graphics/paint/DrawingRecorder.cpp

@@ -64,8 +64,9 @@ DrawingRecorder::~DrawingRecorder()

} else {

RefPtr<const SkPicture> picture = m_context->endRecording();

if (!picture || !picture->approximateOpCount())

- return;

- displayItem = DrawingDisplayItem::create(m_displayItemClient, m_displayItemType, picture);

+ displayItem = DisplayItem::createDummy(m_displayItemClient, m_displayItemType);

+ else

+ displayItem = DrawingDisplayItem::create(m_displayItemClient, m_displayItemType, picture);

}

#ifndef NDEBUG