Source/platform/graphics/paint/DrawingDisplayItem.h - Issue 794323004: Emit dummy display item when recorded picture is empty

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/graphics/paint/DrawingDisplayItem.h

Issue 794323004: Emit dummy display item when recorded picture is empty (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a missed "override" Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/platform/graphics/paint/DisplayItem.cpp ('K') | « Source/platform/graphics/paint/DisplayItem.cpp ('k') | Source/platform/graphics/paint/DrawingRecorder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef DrawingDisplayItem_h	5 #ifndef DrawingDisplayItem_h

6 #define DrawingDisplayItem_h	6 #define DrawingDisplayItem_h

7	7

8 #include "platform/PlatformExport.h"	8 #include "platform/PlatformExport.h"

9 #include "platform/geometry/FloatPoint.h"	9 #include "platform/geometry/FloatPoint.h"

10 #include "platform/graphics/paint/DisplayItem.h"	10 #include "platform/graphics/paint/DisplayItem.h"

(...skipping 13 matching lines...) Expand all Loading...
24 virtual void appendToWebDisplayItemList(WebDisplayItemList*) const override;	24 virtual void appendToWebDisplayItemList(WebDisplayItemList*) const override;

25	25

26 PassRefPtr<const SkPicture> picture() const { return m_picture; }	26 PassRefPtr<const SkPicture> picture() const { return m_picture; }

27	27

28 protected:	28 protected:

29 DrawingDisplayItem(DisplayItemClient client, Type type, PassRefPtr<const SkP icture> picture)	29 DrawingDisplayItem(DisplayItemClient client, Type type, PassRefPtr<const SkP icture> picture)

30 : DisplayItem(client, type), m_picture(picture) { ASSERT(m_picture); }	30 : DisplayItem(client, type), m_picture(picture) { ASSERT(m_picture); }

31	31

32 private:	32 private:

33 #ifndef NDEBUG	33 #ifndef NDEBUG

	34 virtual const char* name() const override { return "Drawing"; }

34 virtual void dumpPropertiesAsDebugString(WTF::StringBuilder&) const override ;	35 virtual void dumpPropertiesAsDebugString(WTF::StringBuilder&) const override ;

35 #endif	36 #endif

36	37

37 RefPtr<const SkPicture> m_picture;	38 RefPtr<const SkPicture> m_picture;

38 };	39 };

39	40

40 } // namespace blink	41 } // namespace blink

41	42

42 #endif // DrawingDisplayItem_h	43 #endif // DrawingDisplayItem_h

OLD	NEW