Issue 794303002: Increase HeartbeatManagerTest.UpdateTimerAfterStart test max time check to

Issue 794303002: Increase HeartbeatManagerTest.UpdateTimerAfterStart test max time check to (Closed)

Created:
6 years ago by zhaoqin

Modified:
6 years ago

Reviewers:
Chirantan Ekbote, Nicolas Zea, zhaoqin1

CC:
chromium-reviews, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Increase HeartbeatManagerTest.UpdateTimerAfterStart test max time check to make it less flaky on memory.fyi bots. BUG=441291 R=chirantan@chromium.org Committed: https://crrev.com/390efc4cec77c5b3c234f891efc260e9f795a2bf Cr-Commit-Position: refs/heads/master@{#308434}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	google_apis/gcm/engine/heartbeat_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (2 generated)

Chirantan Ekbote

lgtm, thanks! I think you might still need owner approval though.

6 years ago (2014-12-11 19:23:32 UTC) #2

zhaoqin1

On 2014/12/11 19:23:32, Chirantan Ekbote wrote: > lgtm, thanks! > > I think you might ...

6 years ago (2014-12-11 19:26:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794303002/1

6 years ago (2014-12-15 21:11:16 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-15 22:04:25 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/390efc4cec77c5b3c234f891efc260e9f795a2bf
Cr-Commit-Position: refs/heads/master@{#308434}