Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Issue 794273002: Introduce SafeBrowsingDatabase::ThreadSafeStateManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a6_dedup_sideeffectfreeWLcode
Patch Set: fix memory management Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
index 839caf5b9122d90cae150932e7ca087f14a62c2b..f2f920a415f9bcf7cc0d55db7109e2cc24e52d7a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
@@ -830,7 +830,8 @@ void SafeBrowsingDatabaseTest::PopulateDatabaseForCacheTest() {
database_->UpdateFinished(true);
// Cache should be cleared after updating.
- EXPECT_TRUE(database_->prefix_gethash_cache_.empty());
+ EXPECT_TRUE(
+ database_->GetUnsynchronizedPrefixGetHashCacheForTesting()->empty());
SBFullHashResult full_hash;
full_hash.list_id = safe_browsing_util::MALWARE;
@@ -854,7 +855,8 @@ TEST_F(SafeBrowsingDatabaseTest, HashCaching) {
PopulateDatabaseForCacheTest();
// We should have both full hashes in the cache.
- EXPECT_EQ(2U, database_->prefix_gethash_cache_.size());
+ EXPECT_EQ(2U,
+ database_->GetUnsynchronizedPrefixGetHashCacheForTesting()->size());
// Test the cache lookup for the first prefix.
std::vector<SBPrefix> prefix_hits;
@@ -910,7 +912,8 @@ TEST_F(SafeBrowsingDatabaseTest, HashCaching) {
database_->UpdateFinished(true);
EXPECT_FALSE(database_->ContainsBrowseUrl(
GURL("http://www.evil.com/malware.html"), &prefix_hits, &cache_hits));
- EXPECT_TRUE(database_->prefix_gethash_cache_.empty());
+ EXPECT_TRUE(
+ database_->GetUnsynchronizedPrefixGetHashCacheForTesting()->empty());
prefix_hits.clear();
cache_hits.clear();
@@ -919,13 +922,13 @@ TEST_F(SafeBrowsingDatabaseTest, HashCaching) {
// cache insert uses Time::Now(). First, store some entries.
PopulateDatabaseForCacheTest();
- std::map<SBPrefix, SBCachedFullHashResult>* hash_cache =
- &database_->prefix_gethash_cache_;
+ SafeBrowsingDatabaseNew::PrefixGetHashCache* hash_cache =
+ database_->GetUnsynchronizedPrefixGetHashCacheForTesting();
EXPECT_EQ(2U, hash_cache->size());
// Now adjust one of the entries times to be in the past.
const SBPrefix key = SBPrefixForString("www.evil.com/malware.html");
- std::map<SBPrefix, SBCachedFullHashResult>::iterator iter =
+ SafeBrowsingDatabaseNew::PrefixGetHashCache::iterator iter =
hash_cache->find(key);
ASSERT_TRUE(iter != hash_cache->end());
iter->second.expire_after = Time::Now() - TimeDelta::FromMinutes(1);
@@ -1885,7 +1888,8 @@ TEST_F(SafeBrowsingDatabaseTest, BrowseFullHashMatching) {
database_->UpdateFinished(true);
// Cache should be cleared after updating.
- EXPECT_TRUE(database_->prefix_gethash_cache_.empty());
+ EXPECT_TRUE(
+ database_->GetUnsynchronizedPrefixGetHashCacheForTesting()->empty());
{
// Now the database doesn't contain kFullHash1_1.
@@ -1922,7 +1926,8 @@ TEST_F(SafeBrowsingDatabaseTest, BrowseFullHashMatching) {
database_->UpdateFinished(true);
// Cache should be cleared after updating.
- EXPECT_TRUE(database_->prefix_gethash_cache_.empty());
+ EXPECT_TRUE(
+ database_->GetUnsynchronizedPrefixGetHashCacheForTesting()->empty());
{
// None are present.
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698