Issue 794243004: chrome: Cleanup some entries from presubmit's exclude list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794243004: chrome: Cleanup some entries from presubmit's exclude list. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

chrome: Cleanup some entries from presubmit's exclude list. They don't seem to be necessary anymore. R=thestig@chromium.org Committed: https://crrev.com/976aee267e18be61bb92f422547c2f9ff3cf6330 Cr-Commit-Position: refs/heads/master@{#308278}

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	chrome/PRESUBMIT.py	View		1 chunk	+0 lines, -12 lines	1 comment	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/794243004/diff/1/chrome/PRESUBMIT.py File chrome/PRESUBMIT.py (left): https://codereview.chromium.org/794243004/diff/1/chrome/PRESUBMIT.py#oldcode42 chrome/PRESUBMIT.py:42: r'gcapi\.cc$', gcapi.cc still exists, but I don't see ...

6 years ago (2014-12-12 01:53:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794243004/1

6 years ago (2014-12-13 16:23:54 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-13 17:07:41 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/976aee267e18be61bb92f422547c2f9ff3cf6330
Cr-Commit-Position: refs/heads/master@{#308278}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages