Source/platform/image-decoders/ImageDecoder.h - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/image-decoders/ImageDecoder.h

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/image-decoders/ImageDecoder.h

diff --git a/Source/platform/image-decoders/ImageDecoder.h b/Source/platform/image-decoders/ImageDecoder.h

index dfb6e54967f1735028ef26c2622783e483318a81..178b6f57dc590c456945b12db5bef28459c9c99e 100644

--- a/Source/platform/image-decoders/ImageDecoder.h

+++ b/Source/platform/image-decoders/ImageDecoder.h

@@ -232,9 +232,9 @@ public:

static qcms_profile* qcmsOutputDeviceProfile()

{

- AtomicallyInitializedStatic(OutputDeviceProfile*, outputDeviceProfile = new OutputDeviceProfile());

+ AtomicallyInitializedStaticReference(OutputDeviceProfile, outputDeviceProfile, new OutputDeviceProfile);

- return outputDeviceProfile->profile();

+ return outputDeviceProfile.profile();

}

#endif

« no previous file with comments | « Source/platform/heap/Visitor.cpp ('k') | Source/web/WebImageCache.cpp » ('j') | Source/wtf/Threading.h » ('J')