Source/platform/graphics/ImageDecodingStore.cpp - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageDecodingStore.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/graphics/ImageDecodingStore.cpp

diff --git a/Source/platform/graphics/ImageDecodingStore.cpp b/Source/platform/graphics/ImageDecodingStore.cpp

index 59d0fa60d8e492a45ef7886dec27ba10183a4d5f..1d7e1c942cf4a2968aa5570dcf69c6f611d2caa7 100644

--- a/Source/platform/graphics/ImageDecodingStore.cpp

+++ b/Source/platform/graphics/ImageDecodingStore.cpp

@@ -53,9 +53,9 @@ ImageDecodingStore::~ImageDecodingStore()

#endif

}

-ImageDecodingStore* ImageDecodingStore::instance()

+ImageDecodingStore& ImageDecodingStore::instance()

{

- AtomicallyInitializedStatic(ImageDecodingStore*, store = ImageDecodingStore::create().leakPtr());

+ AtomicallyInitializedStaticReference(ImageDecodingStore, store, ImageDecodingStore::create().leakPtr());

return store;

}

« no previous file with comments | « Source/platform/graphics/ImageDecodingStore.h ('k') | Source/platform/graphics/ImageDecodingStoreTest.cpp » ('j') | Source/wtf/Threading.h » ('J')